PR164442
When reloading a web page with the load type FrameLoadTypeSame after the initial load, the scale of the web page can became incorrect.
Created attachment 147136 [details] Committed, r=atreat
Comment on attachment 147136 [details] Committed, r=atreat Looks good Jacky!
Committed r120124: <https://trac.webkit.org/changeset/120124>
Reopen it, will fix one more issue.
(In reply to comment #5) > Reopen it, will fix one more issue. Please see another issue's reproduce steps on #comment 6 of PR164442.
Created attachment 149643 [details] Patch 2 This patch is to fix the second issue on #comment 6 of PR164442.
Comment on attachment 149643 [details] Patch 2 It is conceptually strange that FrameLoadTypeStandard dispatchDidFirstVisuallyNonEmptyLayout is called after load finished state. What kind of navigation have FrameLoadTypeStarndard? The way this bug manifests should be stated in the changelog.
(In reply to comment #8) > (From update of attachment 149643 [details]) > It is conceptually strange that FrameLoadTypeStandard dispatchDidFirstVisuallyNonEmptyLayout is called after load finished state. > > What kind of navigation have FrameLoadTypeStarndard? The way this bug manifests should be stated in the changelog. As I have talked with Antonio, I would mention the timer here to be more clear.
Created attachment 149767 [details] Updated patch Updated the patch based on the comments.
Comment on attachment 149767 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=149767&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:1642 > + // For FrameLoadTypeSame or FrameLoadTypeStandard load, the layout timer can be fired which can call dispatchDidFirstVisuallyNonEmptyLayout() loads?
(In reply to comment #11) > (From update of attachment 149767 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=149767&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:1642 > > + // For FrameLoadTypeSame or FrameLoadTypeStandard load, the layout timer can be fired which can call dispatchDidFirstVisuallyNonEmptyLayout() > > loads? Should be load, I use "or" here.
Comment on attachment 149767 [details] Updated patch Committed manually r121355: http://trac.webkit.org/changeset/121355