Bug 88884 – Web Inspector: working copy should be committed even if domain binding returns error.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Committing working copy is about saving file. It should always succeed.

[Pavel Feldman]

Created attachment 147107 [details]
Patch

[Pavel Feldman]

Committed r120186: <http://trac.webkit.org/changeset/120186>

[johnjbarton]

I don't think this fix succeeds because the line

  this.contentChanged(newContent, this._mimeType);

is a notification, not an action causing save.

The save action is in DebuggerResourceBinding.js, in didEditScriptSource(error);
the save is still blocked if (error).

    function didEditScriptSource(error)
    {
        if (error) {
            callback(error);
            return;
        }

        var resource = javaScriptSource.resource();
        if (resource)
            resource.addRevision(newSource);

        callback(null);
    }

See https://code.google.com/p/chromium/issues/detail?id=123242

[Vsevolod Vlasov]

(In reply to comment #3)
> I don't think this fix succeeds because the line
> 
>   this.contentChanged(newContent, this._mimeType);
> 
> is a notification, not an action causing save.
> 
> The save action is in DebuggerResourceBinding.js, in didEditScriptSource(error);
> the save is still blocked if (error).
> 
>     function didEditScriptSource(error)
>     {
>         if (error) {
>             callback(error);
>             return;
>         }
> 
>         var resource = javaScriptSource.resource();
>         if (resource)
>             resource.addRevision(newSource);
> 
>         callback(null);
>     }
> 
> See https://code.google.com/p/chromium/issues/detail?id=123242

Fixed in https://bugs.webkit.org/show_bug.cgi?id=90549