Bug 88865 - [Qt] Handle multiple held buttons in touch mocking.
Summary: [Qt] Handle multiple held buttons in touch mocking.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-12 06:19 PDT by Allan Sandfeld Jensen
Modified: 2012-06-13 08:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.86 KB, patch)
2012-06-12 06:27 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Fix holding released buttons (8.00 KB, patch)
2012-06-12 07:23 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch for landing (8.20 KB, patch)
2012-06-13 05:36 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch for landing (8.21 KB, patch)
2012-06-13 05:38 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-06-12 06:19:41 PDT
The touch mocking logic has a number of problems when multiple mouse buttons are held at the same time, in general the case is just not handled and results in undefined behavior.
Comment 1 Allan Sandfeld Jensen 2012-06-12 06:27:12 PDT
Created attachment 147073 [details]
Patch
Comment 2 Andras Becsi 2012-06-12 07:12:27 PDT
The patch breaks the removal of touch mock poins when simulating pinch-zoom, ie.: using ctrl.

Both mock points remain on the screen if control is released earlier than one of the mouse buttons, and the first remains there if control is released after releasing one or both buttons.
Comment 3 Allan Sandfeld Jensen 2012-06-12 07:23:10 PDT
Created attachment 147079 [details]
Fix holding released buttons
Comment 4 Andras Becsi 2012-06-12 07:51:10 PDT
Comment on attachment 147079 [details]
Fix holding released buttons

LGTM.
Comment 5 Kenneth Rohde Christiansen 2012-06-13 05:26:05 PDT
Comment on attachment 147079 [details]
Fix holding released buttons

View in context: https://bugs.webkit.org/attachment.cgi?id=147079&action=review

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:149
> +                if (mouseEvent->buttons() > mouseEvent->button())

Migth deserve a comment

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:180
> +        // A move can have resulted in multiple buttons, so we need check them out individually.

I would remove 'out'
Comment 6 Allan Sandfeld Jensen 2012-06-13 05:36:26 PDT
Created attachment 147298 [details]
Patch for landing
Comment 7 Allan Sandfeld Jensen 2012-06-13 05:38:06 PDT
Created attachment 147300 [details]
Patch for landing

Now with reviewer
Comment 8 WebKit Review Bot 2012-06-13 08:02:05 PDT
Comment on attachment 147300 [details]
Patch for landing

Clearing flags on attachment: 147300

Committed r120207: <http://trac.webkit.org/changeset/120207>
Comment 9 WebKit Review Bot 2012-06-13 08:02:20 PDT
All reviewed patches have been landed.  Closing bug.