The touch mocking logic has a number of problems when multiple mouse buttons are held at the same time, in general the case is just not handled and results in undefined behavior.
Created attachment 147073 [details] Patch
The patch breaks the removal of touch mock poins when simulating pinch-zoom, ie.: using ctrl. Both mock points remain on the screen if control is released earlier than one of the mouse buttons, and the first remains there if control is released after releasing one or both buttons.
Created attachment 147079 [details] Fix holding released buttons
Comment on attachment 147079 [details] Fix holding released buttons LGTM.
Comment on attachment 147079 [details] Fix holding released buttons View in context: https://bugs.webkit.org/attachment.cgi?id=147079&action=review > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:149 > + if (mouseEvent->buttons() > mouseEvent->button()) Migth deserve a comment > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:180 > + // A move can have resulted in multiple buttons, so we need check them out individually. I would remove 'out'
Created attachment 147298 [details] Patch for landing
Created attachment 147300 [details] Patch for landing Now with reviewer
Comment on attachment 147300 [details] Patch for landing Clearing flags on attachment: 147300 Committed r120207: <http://trac.webkit.org/changeset/120207>
All reviewed patches have been landed. Closing bug.