Bug 88853 - [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
Summary: [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when bu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 70028
  Show dependency treegraph
 
Reported: 2012-06-12 04:13 PDT by Peter Beverloo
Modified: 2012-06-22 09:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.22 KB, patch)
2012-06-12 04:25 PDT, Peter Beverloo
no flags Details | Formatted Diff | Diff
Patch (6.88 KB, patch)
2012-06-15 03:58 PDT, Peter Beverloo
no flags Details | Formatted Diff | Diff
Patch (9.26 KB, patch)
2012-06-22 08:03 PDT, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-06-12 04:13:32 PDT
[Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
Comment 1 Peter Beverloo 2012-06-12 04:25:58 PDT
Created attachment 147052 [details]
Patch
Comment 2 Steve Block 2012-06-13 11:36:31 PDT
Comment on attachment 147052 [details]
Patch

It looks like the same pattern also exists in the following files ...
Source/WTF/WTF.gyp/WTF.gyp
Source/WebCore/WebCore.gyp/WebCore.gyp
Source/WebKit/chromium/WebKitUnitTests.gyp

I imagine it needs fixing there too?
Comment 3 Peter Beverloo 2012-06-15 03:58:10 PDT
Created attachment 147788 [details]
Patch
Comment 4 Peter Beverloo 2012-06-15 04:03:24 PDT
(In reply to comment #2)
> (From update of attachment 147052 [details])
> It looks like the same pattern also exists in the following files ...
> Source/WTF/WTF.gyp/WTF.gyp
> Source/WebCore/WebCore.gyp/WebCore.gyp
> Source/WebKit/chromium/WebKitUnitTests.gyp
> 
> I imagine it needs fixing there too?

Ah yes, sorry. Done. This can be landed after the following patch rolls into WebKit, I can keep an eye out and handle this as soon as that happens.

https://chromiumcodereview.appspot.com/10546152/
Comment 5 Steve Block 2012-06-19 07:13:51 PDT
Comment on attachment 147788 [details]
Patch

Looks like you're still missing WebCore.gyp?
Comment 6 Steve Block 2012-06-22 07:42:19 PDT
It would be great to update this patch and land it soon!
Comment 7 Peter Beverloo 2012-06-22 08:03:10 PDT
Created attachment 149030 [details]
Patch
Comment 8 Steve Block 2012-06-22 08:04:21 PDT
Comment on attachment 149030 [details]
Patch

thanks!
Comment 9 WebKit Review Bot 2012-06-22 09:20:51 PDT
Comment on attachment 149030 [details]
Patch

Clearing flags on attachment: 149030

Committed r121028: <http://trac.webkit.org/changeset/121028>
Comment 10 WebKit Review Bot 2012-06-22 09:20:56 PDT
All reviewed patches have been landed.  Closing bug.