This API has been moved to window.Internals Remove the supported APIs from webkit's chromium port. Reference - https://bugs.webkit.org/show_bug.cgi?id=84406
Created attachment 147535 [details] Patch Removed the chromium port specific code for counterValueForElementById
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 147535 [details] Patch Attachment 147535 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12950750
Comment on attachment 147535 [details] Patch The patch is fine, but it looks like you've got a compile problem to work through.
Looks like someone is using this feature: Source/WebKit/chromium/webkit/glue/webkit_glue.cc: In function 'bool webkit_glue::CounterValueForElementById(WebKit::WebFrame*, const std::string&, string16*)':
That was removed in chromium r141631, so I suspect you just need to roll http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS forward past that revision
Thanks Adam for the review. And yes, this I had logged bug with chromium and removed it from there in r141631. I saw the DEPS has been just updated yesterday past that r141631 (currently r141884) So i will just try to hit the patch again for cr-ews. and if passes will commit.
Created attachment 147718 [details] Patch Another upload for patch for build check of cr-linux
Comment on attachment 147718 [details] Patch Let's see if it compiles!
Comment on attachment 147718 [details] Patch Clearing flags on attachment: 147718 Committed r120408: <http://trac.webkit.org/changeset/120408>
All reviewed patches have been landed. Closing bug.