Bug 88849 - [BlackBerry] Enable MEDIA_STREAM by default
Summary: [BlackBerry] Enable MEDIA_STREAM by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-12 02:41 PDT by Robin Cao
Modified: 2012-06-13 05:29 PDT (History)
7 users (show)

See Also:


Attachments
patch (25.87 KB, patch)
2012-06-12 06:43 PDT, Robin Cao
no flags Details | Formatted Diff | Diff
revised patch (25.88 KB, patch)
2012-06-12 18:14 PDT, Robin Cao
no flags Details | Formatted Diff | Diff
patch for landing (25.86 KB, patch)
2012-06-12 19:59 PDT, Robin Cao
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Cao 2012-06-12 02:41:47 PDT
Enable MEDIA_STREAM by default in the BlackBerry port.
Comment 1 Robin Cao 2012-06-12 06:43:00 PDT
Created attachment 147075 [details]
patch
Comment 2 WebKit Review Bot 2012-06-12 06:46:53 PDT
Attachment 147075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/CMakeLists.tx..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Robin Cao 2012-06-12 18:14:32 PDT
Created attachment 147205 [details]
revised patch
Comment 4 Antonio Gomes 2012-06-12 18:26:07 PDT
Comment on attachment 147205 [details]
revised patch

It looks generally good, Robin.

Could you clarify the use of DeprecatedPeerConnectionHandler class. It does not seem to be used by the patch.
Comment 5 Robin Cao 2012-06-12 18:42:12 PDT
(In reply to comment #4)
> (From update of attachment 147205 [details])
> It looks generally good, Robin.
> 
> Could you clarify the use of DeprecatedPeerConnectionHandler class. It does not seem to be used by the patch.

Thanks for the reivew!

DeprecatedPeerConnectionHandler is used in DeprecatedPeerConnection, see the contractor in Source/WebCore/Modules/mediastream/DeprecatedPeerConnection.cpp.

We need this empty implementations to make it build.
Comment 6 Antonio Gomes 2012-06-12 19:41:39 PDT
Comment on attachment 147205 [details]
revised patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147205&action=review

> Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:29
> +UserMediaClientImpl::UserMediaClientImpl(BlackBerry::WebKit::WebPage* page)

'page' is unneeded.

> Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:45
> +void UserMediaClientImpl::cancelUserMediaRequest(UserMediaRequest* request)

ditto
Comment 7 Robin Cao 2012-06-12 19:45:57 PDT
(In reply to comment #6)
> (From update of attachment 147205 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147205&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:29
> > +UserMediaClientImpl::UserMediaClientImpl(BlackBerry::WebKit::WebPage* page)
> 
> 'page' is unneeded.
> 
> > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:45
> > +void UserMediaClientImpl::cancelUserMediaRequest(UserMediaRequest* request)
> 
> ditto

Good catch, I will fix this before commit.
Comment 8 Robin Cao 2012-06-12 19:59:59 PDT
Created attachment 147221 [details]
patch for landing
Comment 9 WebKit Review Bot 2012-06-13 05:29:07 PDT
Comment on attachment 147221 [details]
patch for landing

Clearing flags on attachment: 147221

Committed r120188: <http://trac.webkit.org/changeset/120188>
Comment 10 WebKit Review Bot 2012-06-13 05:29:12 PDT
All reviewed patches have been landed.  Closing bug.