Bug 88849 – [BlackBerry] Enable MEDIA_STREAM by default

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Robin Cao]

Enable MEDIA_STREAM by default in the BlackBerry port.

[Robin Cao]

Created attachment 147075 [details]
patch

[WebKit Review Bot]

Attachment 147075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/CMakeLists.tx..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Robin Cao]

Created attachment 147205 [details]
revised patch

[Antonio Gomes]

Comment on attachment 147205 [details]
revised patch

It looks generally good, Robin.

Could you clarify the use of DeprecatedPeerConnectionHandler class. It does not seem to be used by the patch.

[Robin Cao]

(In reply to comment #4)
> (From update of attachment 147205 [details])
> It looks generally good, Robin.
> 
> Could you clarify the use of DeprecatedPeerConnectionHandler class. It does not seem to be used by the patch.

Thanks for the reivew!

DeprecatedPeerConnectionHandler is used in DeprecatedPeerConnection, see the contractor in Source/WebCore/Modules/mediastream/DeprecatedPeerConnection.cpp.

We need this empty implementations to make it build.

[Antonio Gomes]

Comment on attachment 147205 [details]
revised patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147205&action=review

> Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:29
> +UserMediaClientImpl::UserMediaClientImpl(BlackBerry::WebKit::WebPage* page)

'page' is unneeded.

> Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:45
> +void UserMediaClientImpl::cancelUserMediaRequest(UserMediaRequest* request)

ditto

[Robin Cao]

(In reply to comment #6)
> (From update of attachment 147205 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147205&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:29
> > +UserMediaClientImpl::UserMediaClientImpl(BlackBerry::WebKit::WebPage* page)
> 
> 'page' is unneeded.
> 
> > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:45
> > +void UserMediaClientImpl::cancelUserMediaRequest(UserMediaRequest* request)
> 
> ditto

Good catch, I will fix this before commit.

[Robin Cao]

Created attachment 147221 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 147221 [details]
patch for landing

Clearing flags on attachment: 147221

Committed r120188: <http://trac.webkit.org/changeset/120188>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.