Bug 88843 - [Shadow DOM] Some distribution invalidation can drop necessary reattachment.
Summary: [Shadow DOM] Some distribution invalidation can drop necessary reattachment.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 72352
  Show dependency tree / graph
 
Reported: 2012-06-11 23:53 PDT by Hajime Morrita
Modified: 2012-07-17 21:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.48 KB, patch)
2012-06-12 22:24 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (7.70 KB, patch)
2012-07-16 20:40 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-06-11 23:53:28 PDT 
This is sub-bug of Bug 88747.
Comment 1 Hajime Morrita 2012-06-11 23:55:17 PDT 
repro:

<!DOCTYPE html>
<html>
<body>
<div id="host" class="host"><div>host content</div></div>
<script>
if (window.layoutTestController)
    window.layoutTestController.waitUntilDone();
var root = new WebKitShadowRoot(document.querySelector('#host'));
root.innerHTML = '<style>something { }</style>' +
                 'child<div>child of child<content></content></div>';
window.setTimeout(function() {
    if (window.layoutTestController)
        window.layoutTestController.notifyDone();
}, 0);
</script>
</body>
</html>
Comment 2 Hajime Morrita 2012-06-12 22:24:19 PDT 
Created attachment 147231 [details]
Patch
Comment 3 Hajime Morrita 2012-06-14 17:27:26 PDT 
Dimitri, could you take a look?
Comment 4 Dimitri Glazkov (Google) 2012-07-16 16:31:20 PDT 
Comment on attachment 147231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147231&action=review

> Source/WebCore/ChangeLog:3
> +        [Shadow DOM] <style> prevent distributed content from rendering.

prevent - prevents?

The bug title doesn't seem very precise in describing the problem. You can do better! :)

> Source/WebCore/dom/ElementShadow.h:67
> +        InvalidateAndForcesReattach

InvalidateAndForcesReattach -> InvalidateAndForceReattach
Comment 5 Hajime Morrita 2012-07-16 20:15:15 PDT 
Thanks for taking look at this, Dimitri!
Comment 6 Hajime Morrita 2012-07-16 20:40:59 PDT 
Created attachment 152690 [details]
Patch
Comment 7 Hajime Morrita 2012-07-16 20:43:13 PDT 
(In reply to comment #5)
> Thanks for taking look at this, Dimitri!
... and just updated the patch.
Comment 8 WebKit Review Bot 2012-07-17 21:05:40 PDT 
Comment on attachment 152690 [details]
Patch

Clearing flags on attachment: 152690

Committed r122915: <http://trac.webkit.org/changeset/122915>
Comment 9 WebKit Review Bot 2012-07-17 21:05:45 PDT 
All reviewed patches have been landed.  Closing bug.