[Chromium] Browser Plugin: Expose advanceFocus to WebKit API so that guests can advance focus of theirs embedders
Created attachment 146983 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 146983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146983&action=review > Source/WebKit/chromium/public/WebView.h:196 > + // The browser plugin needs to be able to tell its embedder when the guest > + // is done tabbing through controls and wants its embedder to advance its > + // tab position. This information belongs in the ChangeLog. We use comments in these header to describe what the functions do, not why we added them originally.
Created attachment 147409 [details] Patch
Comment on attachment 146983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146983&action=review Hi Adam, Could you please take another look? Thanks. >> Source/WebKit/chromium/public/WebView.h:196 >> + // tab position. > > This information belongs in the ChangeLog. We use comments in these header to describe what the functions do, not why we added them originally. Done.
Comment on attachment 147409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147409&action=review > Source/WebKit/chromium/public/WebView.h:197 > nit: preserve two lines of whitespace before section comment
Created attachment 149087 [details] Patch
Comment on attachment 149087 [details] Patch Clearing flags on attachment: 149087 Committed r121057: <http://trac.webkit.org/changeset/121057>
All reviewed patches have been landed. Closing bug.