Bug 88816 – Don't consider show warnings in the garden-o-matic UI for non-layout test failures

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

Don't consider show warnings in the garden-o-matic UI for non-layout test failures

[Ojan Vafai]

Created attachment 146944 [details]
Patch

[Dirk Pranke]

Comment on attachment 146944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146944&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:50
> +    return step.results[0] > 0 && step.text.indexOf('warning') == -1;

Does this work with the webkit lint step? Do we want to display those errors?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:585
> +var kExampleBuildInfoWithTaskKillWarning = {

Do we really need 200 lines of sample data here?

[Ojan Vafai]

Created attachment 146948 [details]
Patch

[Ojan Vafai]

Comment on attachment 146944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146944&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:50
>> +    return step.results[0] > 0 && step.text.indexOf('warning') == -1;
> 
> Does this work with the webkit lint step? Do we want to display those errors?

Yes the webkit lint tests as step.text == ['webkit_lint', 'failed']. It is correctly not a warning.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:585
>> +var kExampleBuildInfoWithTaskKillWarning = {
> 
> Do we really need 200 lines of sample data here?

Good point. I cut out some more. I'm hesitant to cut out too much as we might end up writing other code that touches other parts of the output over time.

At the same time, it's possible for the actual bot output to change. Tried to walk a middle ground here. Hopefully you're happier the with the new version.

[Dirk Pranke]

thanks!

[WebKit Review Bot]

Comment on attachment 146948 [details]
Patch

Clearing flags on attachment: 146948

Committed r120019: <http://trac.webkit.org/changeset/120019>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.