Bug 88809 - [BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
Summary: [BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) doe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-11 14:27 PDT by Antonio Gomes
Modified: 2012-06-11 15:04 PDT (History)
1 user (show)

See Also:

Attachments
(committed r120010, r=rbuis) patch (4.31 KB, patch)
2012-06-11 14:35 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-06-11 14:27:49 PDT 
SSIA

patch coming..
Comment 1 Antonio Gomes 2012-06-11 14:35:18 PDT 
Created attachment 146914 [details]
(committed r120010, r=rbuis) patch
Comment 2 Rob Buis 2012-06-11 15:02:18 PDT 
Comment on attachment 146914 [details]
(committed r120010, r=rbuis) patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146914&action=review

Looks good, but please fix before landing.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:740
>          fullScreenRenderer->style()->setWidth(Length(width, Fixed));

As discussed, better check fullScreenRenderer->style as well.