Bug 88808 - [BlackBerry] Fix crash in InputHandler
: [BlackBerry] Fix crash in InputHandler
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-11 14:25 PDT by Crystal Zhang
Modified: 2012-06-12 10:29 PDT (History)
2 users (show)

See Also:


Attachments
patch (2.82 KB, patch)
2012-06-11 15:11 PDT, Crystal Zhang
tonikitoo: review+
Details | Formatted Diff | Diff
upated patch (2.84 KB, patch)
2012-06-11 15:46 PDT, Crystal Zhang
tonikitoo: review+
tonikitoo: commit‑queue-
Details | Formatted Diff | Diff
updated patch (2.86 KB, patch)
2012-06-12 08:14 PDT, Crystal Zhang
no flags Details | Formatted Diff | Diff
updated patch (2.88 KB, patch)
2012-06-12 08:22 PDT, Crystal Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Crystal Zhang 2012-06-11 14:25:53 PDT
m_page is destroyed before InputHandler, so should move the call to destroy popup to ~WebPagePrivate().
Comment 1 Crystal Zhang 2012-06-11 15:11:01 PDT
Created attachment 146927 [details]
patch
Comment 2 Antonio Gomes 2012-06-11 15:37:58 PDT
chrystal is doing a change..
Comment 3 Crystal Zhang 2012-06-11 15:46:41 PDT
Created attachment 146938 [details]
upated patch
Comment 4 Antonio Gomes 2012-06-11 16:49:08 PDT
Comment on attachment 146938 [details]
upated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146938&action=review

> Source/WebKit/blackberry/ChangeLog:8
> +        m_page is destroyed before InputHandler, so should move the call to destroy popup to ~WebPagePrivate().

needs to update it :(
Comment 5 Crystal Zhang 2012-06-12 08:14:59 PDT
Created attachment 147089 [details]
updated patch
Comment 6 Crystal Zhang 2012-06-12 08:22:22 PDT
Created attachment 147090 [details]
updated patch
Comment 7 WebKit Review Bot 2012-06-12 10:29:16 PDT
Comment on attachment 147090 [details]
updated patch

Clearing flags on attachment: 147090

Committed r120091: <http://trac.webkit.org/changeset/120091>
Comment 8 WebKit Review Bot 2012-06-12 10:29:20 PDT
All reviewed patches have been landed.  Closing bug.