Bug 88808 - [BlackBerry] Fix crash in InputHandler
: [BlackBerry] Fix crash in InputHandler
Status: RESOLVED FIXED
: WebKit
WebKit BlackBerry
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-06-11 14:25 PST by
Modified: 2012-06-12 10:29 PST (History)


Attachments
patch (2.82 KB, patch)
2012-06-11 15:11 PST, Crystal Zhang
tonikitoo: review+
Review Patch | Details | Formatted Diff | Diff
upated patch (2.84 KB, patch)
2012-06-11 15:46 PST, Crystal Zhang
tonikitoo: review+
tonikitoo: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
updated patch (2.86 KB, patch)
2012-06-12 08:14 PST, Crystal Zhang
no flags Review Patch | Details | Formatted Diff | Diff
updated patch (2.88 KB, patch)
2012-06-12 08:22 PST, Crystal Zhang
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-06-11 14:25:53 PST
m_page is destroyed before InputHandler, so should move the call to destroy popup to ~WebPagePrivate().
------- Comment #1 From 2012-06-11 15:11:01 PST -------
Created an attachment (id=146927) [details]
patch
------- Comment #2 From 2012-06-11 15:37:58 PST -------
chrystal is doing a change..
------- Comment #3 From 2012-06-11 15:46:41 PST -------
Created an attachment (id=146938) [details]
upated patch
------- Comment #4 From 2012-06-11 16:49:08 PST -------
(From update of attachment 146938 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=146938&action=review

> Source/WebKit/blackberry/ChangeLog:8
> +        m_page is destroyed before InputHandler, so should move the call to destroy popup to ~WebPagePrivate().

needs to update it :(
------- Comment #5 From 2012-06-12 08:14:59 PST -------
Created an attachment (id=147089) [details]
updated patch
------- Comment #6 From 2012-06-12 08:22:22 PST -------
Created an attachment (id=147090) [details]
updated patch
------- Comment #7 From 2012-06-12 10:29:16 PST -------
(From update of attachment 147090 [details])
Clearing flags on attachment: 147090

Committed r120091: <http://trac.webkit.org/changeset/120091>
------- Comment #8 From 2012-06-12 10:29:20 PST -------
All reviewed patches have been landed.  Closing bug.