Bug 88798 - Separate RemoveID test cases in video-media-source-add-and-remove-ids.html
Summary: Separate RemoveID test cases in video-media-source-add-and-remove-ids.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anna Cavender
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-11 13:11 PDT by Anna Cavender
Modified: 2012-06-12 11:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.67 KB, patch)
2012-06-11 14:58 PDT, Anna Cavender
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (592.51 KB, application/zip)
2012-06-11 17:56 PDT, WebKit Review Bot
no flags Details
with test expectations added (5.68 KB, patch)
2012-06-12 01:29 PDT, Anna Cavender
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Cavender 2012-06-11 13:11:43 PDT
The Chrome implementation will (until we fix it) not support adding an id again after removing an id.  I plan to separate the existing testRemoveIDFailureCases to avoid doing that, and add a test that explicitly tests adding ids after a remove (we will fail that test for while).
Comment 1 Anna Cavender 2012-06-11 14:58:08 PDT
Created attachment 146922 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-11 17:56:41 PDT
Comment on attachment 146922 [details]
Patch

Attachment 146922 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12945405

New failing tests:
http/tests/media/media-source/video-media-source-add-and-remove-ids.html
Comment 3 WebKit Review Bot 2012-06-11 17:56:45 PDT
Created attachment 146980 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Anna Cavender 2012-06-11 19:46:02 PDT
I should have added that these changes will not pass until the chromium changes land (which is pending these changes).
Comment 5 Anna Cavender 2012-06-12 01:29:35 PDT
Created attachment 147035 [details]
with test expectations added
Comment 6 Eric Carlson 2012-06-12 10:39:50 PDT
Comment on attachment 147035 [details]
with test expectations added

rs=me
Comment 7 Anna Cavender 2012-06-12 10:50:40 PDT
Comment on attachment 147035 [details]
with test expectations added

Thanks Eric!
Comment 8 WebKit Review Bot 2012-06-12 11:52:30 PDT
Comment on attachment 147035 [details]
with test expectations added

Clearing flags on attachment: 147035

Committed r120097: <http://trac.webkit.org/changeset/120097>
Comment 9 WebKit Review Bot 2012-06-12 11:52:38 PDT
All reviewed patches have been landed.  Closing bug.