WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 88791
Web Inspector: use jsdifflib for revision diff calculation.
https://bugs.webkit.org/show_bug.cgi?id=88791
Summary
Web Inspector: use jsdifflib for revision diff calculation.
Pavel Feldman
Reported
2012-06-11 11:00:28 PDT
Present diff calculation is incomplete, it does not properly handle the following case: [a, b, c, d, e, f, g, h] => [c, d, e, f, g, h, a, b] It detects [a, b] as the lcs. I imported jsdifflib from
https://github.com/cemerick/jsdifflib
. It has BSD license that is compatible with WebKit.
Attachments
Patch
(27.61 KB, patch)
2012-06-11 11:11 PDT
,
Pavel Feldman
vsevik
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-06-11 11:11:54 PDT
Created
attachment 146877
[details]
Patch
Pavel Feldman
Comment 2
2012-06-12 09:44:58 PDT
Committed
r120085
: <
http://trac.webkit.org/changeset/120085
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug