Bug 88788 – IndexedDB: Object stores are not successfully deleted

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joshua Bell]

IndexedDB: Object stores are not successfully deleted

[Joshua Bell]

Created attachment 146882 [details]
Patch

[Joshua Bell]

tony@ - r?

Wanted to land this separately from https://bugs.webkit.org/show_bug.cgi?id=83074

That patch will include a test for this scenario.

[Tony Chang]

Comment on attachment 146882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146882&action=review

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:1117
> +    return (result < 0) ? -1 : (result > 0) ? 1 : result;

Nit: I find nested ternary operators hard to read.  I would probably do:
if (result < 0)
    return -1;
return (result > 0) ? 1 : 0;

[Joshua Bell]

Created attachment 146886 [details]
Patch for landing

[Joshua Bell]

Comment on attachment 146886 [details]
Patch for landing

This can be tested by a chromium webkit_unit_test; will upload a new patch.

[Joshua Bell]

Created attachment 146894 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 146894 [details]
Patch for landing

Clearing flags on attachment: 146894

Committed r120014: <http://trac.webkit.org/changeset/120014>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.