Bug 88788 - IndexedDB: Object stores are not successfully deleted
Summary: IndexedDB: Object stores are not successfully deleted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-11 10:52 PDT by Joshua Bell
Modified: 2012-06-11 15:42 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.93 KB, patch)
2012-06-11 11:32 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch for landing (1.95 KB, patch)
2012-06-11 12:04 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch for landing (4.06 KB, patch)
2012-06-11 13:31 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-06-11 10:52:55 PDT
IndexedDB: Object stores are not successfully deleted
Comment 1 Joshua Bell 2012-06-11 11:32:21 PDT
Created attachment 146882 [details]
Patch
Comment 2 Joshua Bell 2012-06-11 11:34:34 PDT
tony@ - r?

Wanted to land this separately from https://bugs.webkit.org/show_bug.cgi?id=83074

That patch will include a test for this scenario.
Comment 3 Tony Chang 2012-06-11 11:41:01 PDT
Comment on attachment 146882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146882&action=review

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:1117
> +    return (result < 0) ? -1 : (result > 0) ? 1 : result;

Nit: I find nested ternary operators hard to read.  I would probably do:
if (result < 0)
    return -1;
return (result > 0) ? 1 : 0;
Comment 4 Joshua Bell 2012-06-11 12:04:23 PDT
Created attachment 146886 [details]
Patch for landing
Comment 5 Joshua Bell 2012-06-11 13:15:52 PDT
Comment on attachment 146886 [details]
Patch for landing

This can be tested by a chromium webkit_unit_test; will upload a new patch.
Comment 6 Joshua Bell 2012-06-11 13:31:52 PDT
Created attachment 146894 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-06-11 15:42:10 PDT
Comment on attachment 146894 [details]
Patch for landing

Clearing flags on attachment: 146894

Committed r120014: <http://trac.webkit.org/changeset/120014>
Comment 8 WebKit Review Bot 2012-06-11 15:42:15 PDT
All reviewed patches have been landed.  Closing bug.