Bug 88784 - Speech JavaScript API: Make SpeechRecognitionError an Event
Summary: Speech JavaScript API: Make SpeechRecognitionError an Event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks: 80261
  Show dependency tree / graph
 
Reported: 2012-06-11 08:07 PDT by Hans Wennborg
Modified: 2012-06-12 03:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (18.99 KB, patch)
2012-06-11 08:13 PDT, Hans Wennborg 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (509.90 KB, application/zip)
2012-06-11 12:46 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2012-06-11 08:07:48 PDT 
Speech JavaScript API: Make SpeechRecognitionError an Event
Comment 1 Hans Wennborg 2012-06-11 08:13:23 PDT 
Created attachment 146858 [details]
Patch
Comment 2 Adam Barth 2012-06-11 10:32:42 PDT 
Comment on attachment 146858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146858&action=review

> Source/WebCore/Modules/speech/SpeechRecognitionError.h:52
> +    static PassRefPtr<SpeechRecognitionError> create() { return create(OTHER, ""); }

Consider using emptyString() rather than "" if this is used only on the main thread.  (It's ever so slightly faster.)

> LayoutTests/ChangeLog:10
> +        * fast/speech/scripted/speechrecognition-errors.html: Added.

It looks like you forgot to "svn add" the -expected.txt file.  This patch will cause the bots to turn red because this test is missing results.
Comment 3 WebKit Review Bot 2012-06-11 12:46:19 PDT 
Comment on attachment 146858 [details]
Patch

Attachment 146858 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12942316

New failing tests:
fast/events/constructors/speech-recognition-event-constructor.html
Comment 4 WebKit Review Bot 2012-06-11 12:46:23 PDT 
Created attachment 146888 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Hans Wennborg 2012-06-12 03:38:01 PDT 
(In reply to comment #2)
> (From update of attachment 146858 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146858&action=review

Thanks for the review!

> > Source/WebCore/Modules/speech/SpeechRecognitionError.h:52
> > +    static PassRefPtr<SpeechRecognitionError> create() { return create(OTHER, ""); }
> 
> Consider using emptyString() rather than "" if this is used only on the main thread.  (It's ever so slightly faster.)

Done.

> > LayoutTests/ChangeLog:10
> > +        * fast/speech/scripted/speechrecognition-errors.html: Added.
> 
> It looks like you forgot to "svn add" the -expected.txt file.  This patch will cause the bots to turn red because this test is missing results.

Ouch! Thanks for spotting.
Comment 6 Hans Wennborg 2012-06-12 03:38:59 PDT 
Committed r120053: <http://trac.webkit.org/changeset/120053>