Bug 88784 – Speech JavaScript API: Make SpeechRecognitionError an Event

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hans Wennborg]

Speech JavaScript API: Make SpeechRecognitionError an Event

[Hans Wennborg]

Created attachment 146858 [details]
Patch

[Adam Barth]

Comment on attachment 146858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146858&action=review

> Source/WebCore/Modules/speech/SpeechRecognitionError.h:52
> +    static PassRefPtr<SpeechRecognitionError> create() { return create(OTHER, ""); }

Consider using emptyString() rather than "" if this is used only on the main thread.  (It's ever so slightly faster.)

> LayoutTests/ChangeLog:10
> +        * fast/speech/scripted/speechrecognition-errors.html: Added.

It looks like you forgot to "svn add" the -expected.txt file.  This patch will cause the bots to turn red because this test is missing results.

[WebKit Review Bot]

Comment on attachment 146858 [details]
Patch

Attachment 146858 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12942316

New failing tests:
fast/events/constructors/speech-recognition-event-constructor.html

[WebKit Review Bot]

Created attachment 146888 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Hans Wennborg]

(In reply to comment #2)
> (From update of attachment 146858 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146858&action=review

Thanks for the review!

> > Source/WebCore/Modules/speech/SpeechRecognitionError.h:52
> > +    static PassRefPtr<SpeechRecognitionError> create() { return create(OTHER, ""); }
> 
> Consider using emptyString() rather than "" if this is used only on the main thread.  (It's ever so slightly faster.)

Done.

> > LayoutTests/ChangeLog:10
> > +        * fast/speech/scripted/speechrecognition-errors.html: Added.
> 
> It looks like you forgot to "svn add" the -expected.txt file.  This patch will cause the bots to turn red because this test is missing results.

Ouch! Thanks for spotting.

[Hans Wennborg]

Committed r120053: <http://trac.webkit.org/changeset/120053>