Bug 88777 - Add QML api for setting device width and height
Summary: Add QML api for setting device width and height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-11 06:20 PDT by Kenneth Rohde Christiansen
Modified: 2012-06-11 06:53 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.81 KB, patch)
2012-06-11 06:29 PDT, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Patch (11.83 KB, patch)
2012-06-11 06:35 PDT, Kenneth Rohde Christiansen 		hausmann: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2012-06-11 06:20:48 PDT 
SSIA.

If a valid width/height is not set, we use the viewport dimensions for the viewport computation.
Comment 1 Kenneth Rohde Christiansen 2012-06-11 06:29:52 PDT 
Created attachment 146845 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-06-11 06:35:29 PDT 
Created attachment 146846 [details]
Patch
Comment 3 Simon Hausmann 2012-06-11 06:47:49 PDT 
Comment on attachment 146846 [details]
Patch

r=me, but please add the missing device{Width/Height}Changed signal emissions in the setters when the value changed.
Comment 4 zalan 2012-06-11 06:49:06 PDT 
it looks okay to me, not sure whether QQuickWebViewExperimental should have this set-get pair, but I am not an API person.
Comment 5 zalan 2012-06-11 06:49:36 PDT 
ah, r+ already. goody then.
Comment 6 Kenneth Rohde Christiansen 2012-06-11 06:53:39 PDT 
Landed in r119975