Fix RequestAnimationFrameCallback.handleEvent return type in IDL.

[Pavel Podivilov]

Fix RequestAnimationFrameCallback.handleEvent return type in IDL.

[Pavel Podivilov]

Created attachment 146844 [details]
Patch

[Build Bot]

Comment on attachment 146844 [details]
Patch

Attachment 146844 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12925951

[Build Bot]

Comment on attachment 146844 [details]
Patch

Attachment 146844 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12941326

[Early Warning System Bot]

Comment on attachment 146844 [details]
Patch

Attachment 146844 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12939386

[WebKit Review Bot]

Comment on attachment 146844 [details]
Patch

Attachment 146844 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12947170

[Early Warning System Bot]

Comment on attachment 146844 [details]
Patch

Attachment 146844 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12946166

[Gyuyoung Kim]

Comment on attachment 146844 [details]
Patch

Attachment 146844 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12940334

[James Robinson]

Comment on attachment 146844 [details]
Patch

Looks like you have some compilation errors to fix!

I'm not sure what the COMPILE_ASSERT problem is, but you do need to change the c++ bindings code type from bool to void to fix at least some of the errors.

[Pavel Podivilov]

Created attachment 147591 [details]
Patch

[Pavel Podivilov]

Created attachment 147593 [details]
Patch

[James Robinson]

Comment on attachment 147593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147593&action=review

> Source/WebCore/ChangeLog:8
> +        C++ callback's handleEvent implementation should always return bool,
> +        since its return type has nothing to do with IDL return type.

why should C++'s handleEvent return bool?

[Pavel Podivilov]

C++ GeneratedCallbackName::handleEvent returns negated result of WebCore::invokeCallback invocation for all callback types: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm#L3133.

WebCore::invokeCallback returns true iff there was uncaught exception in JS callback:
http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp#L71

RequestAnimationFrameCallback::handleEvent result is ignored as well, see ScriptedAnimationController::serviceScriptedAnimations.  But in any case, it seems unrelated to IDL return type.

[Anders Carlsson]

Comment on attachment 147593 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.

[Alexey Proskuryakov]

It's now:

callback RequestAnimationFrameCallback = void (unrestricted double highResTime);

Updated in https://trac.webkit.org/r208408

[Radar WebKit Bug Importer]

<rdar://problem/54167896>