Bug 88773 - [BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside
Summary: [BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mary Wu
URL:
Keywords:
Depends on: 88965
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-11 03:22 PDT by Mary Wu
Modified: 2014-01-28 08:12 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2012-06-11 03:42 PDT, Mary Wu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2012-06-11 03:22:54 PDT 
if there's no data in the page, we should still pass on the dataReceived event to client. It's critical to two cases: plugin and download.
Otherwise if we only send notifyClose without dataReceived, FrameLoaderBlackBerry will create pluginView in close and have no chance to clear it later; 
download will create DownloadFilterStream in notifyClose and can't get any update afterwards since NetworkStream already closed.
Comment 1 Mary Wu 2012-06-11 03:41:05 PDT 
related to RIM PR# 164563
Comment 2 Mary Wu 2012-06-11 03:42:12 PDT 
Created attachment 146820 [details]
Patch
Comment 3 Rob Buis 2012-06-11 06:56:22 PDT 
Comment on attachment 146820 [details]
Patch

Looks good.
Comment 4 WebKit Review Bot 2012-06-11 20:46:51 PDT 
Comment on attachment 146820 [details]
Patch

Clearing flags on attachment: 146820

Committed r120036: <http://trac.webkit.org/changeset/120036>
Comment 5 WebKit Review Bot 2012-06-11 20:46:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-06-12 23:10:07 PDT 
Re-opened since this is blocked by 88965