Bug 88768 - Validate form state strings in FormController::setStateForNewFormElements()
Summary: Validate form state strings in FormController::setStateForNewFormElements()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 89070
Blocks: 23346
  Show dependency tree / graph
 
Reported: 2012-06-11 01:04 PDT by Kent Tamura
Modified: 2012-06-14 21:34 PDT (History)
11 users (show)

See Also:

Attachments
WIP (18.68 KB, patch)
2012-06-14 00:30 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
WIP 2 (24.93 KB, patch)
2012-06-14 04:36 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
WIP 3 (24.73 KB, patch)
2012-06-14 04:52 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
WIP 4 (24.76 KB, patch)
2012-06-14 05:11 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (26.84 KB, patch)
2012-06-14 05:23 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (623.45 KB, application/zip)
2012-06-14 10:53 PDT, WebKit Review Bot 		no flags Details
Patch 2 (26.84 KB, patch)
2012-06-14 17:43 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 3 (25.29 KB, patch)
2012-06-14 19:29 PDT, Kent Tamura 		morrita: review+
morrita: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-06-11 01:04:42 PDT 
Validate form state strings in FormController::setStateForNewFormElements()
Comment 1 Kent Tamura 2012-06-14 00:30:29 PDT 
Created attachment 147508 [details]
WIP
Comment 2 Build Bot 2012-06-14 01:09:31 PDT 
Comment on attachment 147508 [details]
WIP

Attachment 147508 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12952487
Comment 3 Kent Tamura 2012-06-14 04:36:28 PDT 
Created attachment 147553 [details]
WIP 2
Comment 4 Gustavo Noronha (kov) 2012-06-14 04:47:31 PDT 
Comment on attachment 147553 [details]
WIP 2

Attachment 147553 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12955365
Comment 5 Kent Tamura 2012-06-14 04:52:06 PDT 
Created attachment 147555 [details]
WIP 3
Comment 6 Gustavo Noronha (kov) 2012-06-14 05:05:26 PDT 
Comment on attachment 147555 [details]
WIP 3

Attachment 147555 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12954375
Comment 7 Kent Tamura 2012-06-14 05:11:29 PDT 
Created attachment 147559 [details]
WIP 4
Comment 8 Kent Tamura 2012-06-14 05:23:07 PDT 
Created attachment 147561 [details]
Patch
Comment 9 WebKit Review Bot 2012-06-14 10:53:33 PDT 
Comment on attachment 147561 [details]
Patch

Attachment 147561 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12965227

New failing tests:
fast/forms/state-restore-broken-state.html
Comment 10 WebKit Review Bot 2012-06-14 10:53:38 PDT 
Created attachment 147616 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 11 Kent Tamura 2012-06-14 17:43:22 PDT 
Created attachment 147692 [details]
Patch 2

Fix the test result
Comment 12 Kent Tamura 2012-06-14 19:29:42 PDT 
Created attachment 147713 [details]
Patch 3

Remove binding code
Comment 13 Hajime Morrita 2012-06-14 21:22:59 PDT 
Comment on attachment 147713 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=147713&action=review

> Source/WebCore/ChangeLog:11
> +        - A future versio of WebKit might change the format

Typo: versio
Comment 14 Kent Tamura 2012-06-14 21:34:41 PDT 
Committed r120397: <http://trac.webkit.org/changeset/120397>