Bug 88765 - [CMAKE][EFL] Remove duplicated executable output path
Summary: [CMAKE][EFL] Remove duplicated executable output path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-11 00:51 PDT by Gyuyoung Kim
Modified: 2012-06-11 17:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2012-06-11 00:54 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-06-11 00:51:29 PDT 
CMake files for EFL port have redefined executable output path. However, EFL port doesn't need to define again because it is already defined in top-level CMake file.

In CMakeLists.txt on top level directory, output directory is already defined.

39	SET(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
40	SET(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
41	SET(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)

(http://trac.webkit.org/browser/trunk/CMakeLists.txt#L41)
Comment 1 Gyuyoung Kim 2012-06-11 00:54:16 PDT 
Created attachment 146802 [details]
Patch
Comment 2 Gyuyoung Kim 2012-06-11 00:59:55 PDT 
CC'ing patrick.
Comment 3 Daniel Bates 2012-06-11 17:43:22 PDT 
Comment on attachment 146802 [details]
Patch

OK
Comment 4 WebKit Review Bot 2012-06-11 17:58:42 PDT 
Comment on attachment 146802 [details]
Patch

Clearing flags on attachment: 146802

Committed r120024: <http://trac.webkit.org/changeset/120024>
Comment 5 WebKit Review Bot 2012-06-11 17:58:47 PDT 
All reviewed patches have been landed.  Closing bug.