Fixes offset of WKPageLoaderClient for version 0 by adding didDetectXSSForFrame.
Created attachment 146801 [details] proposed patch
I don't understand the versioning scheme enough to tell what this does exactly. Could you please explain what this actually fixes? One would expect version 0 to have stabilized long ago.
(In reply to comment #2) > I don't understand the versioning scheme enough to tell what this does exactly. Could you please explain what this actually fixes? One would expect version 0 to have stabilized long ago. interfaceSizesByVersion it's a table that keeps size of structure for each version of client interface. If someone wants to change it (because of API change) then the structure should be extended by adding a new callback to the current and bump version. For example, version 0 of WKBundlePageLoaderClient includes members of structure from 0 to 17. To include last callback (didHandleOnloadEventsForFrame) we have to give offset to next one (didLayoutForFrame) but it isn't attached. This patch adds didDetectXSSForFrame callback for version 0 of WKPageLoaderClient because offset should be set to next member of structure.
Comment on attachment 146801 [details] proposed patch Please explain in the ChangeLog that the offset should be of the first new callback that was added in the new version. Looks fine otherwise!
Created attachment 147246 [details] updated ChangeLog according to Anders' review Thanks Anders for review!
Comment on attachment 147246 [details] updated ChangeLog according to Anders' review Clearing flags on attachment: 147246 Committed r120290: <http://trac.webkit.org/changeset/120290>
All reviewed patches have been landed. Closing bug.