Bug 88744 – [WebSocket] WebSocket object in Worker Context should fire error event when it fails connection.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Li Yin]

Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
If the user agent was required to fail the websocket connection or the WebSocket connection is closed with prejudice, fire a simple event named error at the WebSocket object.

This bug is similar with Bug 86958, but it is still required to fix in Worker Context.

[Li Yin]

Created attachment 146770 [details]
Patch

[Yuta Kitamura]

Comment on attachment 146770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146770&action=review

Looks okay except for one nitpick.

> LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:14
> +function testPassed(message)
> +{
> +    postMessage("Pass: " + message);
> +}

The output should look similar to postResult()'s.

[Li Yin]

(In reply to comment #2)
> (From update of attachment 146770 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146770&action=review
> 
> Looks okay except for one nitpick.
> 
> > LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:14
> > +function testPassed(message)
> > +{
> > +    postMessage("Pass: " + message);
> > +}
> 
> The output should look similar to postResult()'s.

OK, I will change the style, thanks for your review.

[Li Yin]

(In reply to comment #2)
> (From update of attachment 146770 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146770&action=review
> 
> Looks okay except for one nitpick.
> 
> > LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:14
> > +function testPassed(message)
> > +{
> > +    postMessage("Pass: " + message);
> > +}
> 
> The output should look similar to postResult()'s.

postResult()'s style looks strange.
PASS PASS: ****, maybe one PASS is enough.
Maybe style of http/tests/websocket/tests/hybi/close.html looks more nice :)

[Li Yin]

Created attachment 146803 [details]
Patch

[Li Yin]

Hi Kent,
   Could you have a look? 
   Thanks in advance.

[Li Yin]

Thanks Kent for your review.

[WebKit Review Bot]

Comment on attachment 146803 [details]
Patch

Clearing flags on attachment: 146803

Committed r120291: <http://trac.webkit.org/changeset/120291>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.