Bug 88738 - Some additional tweaks to keep TreeShared code simple/clean
Summary: Some additional tweaks to keep TreeShared code simple/clean
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-10 10:47 PDT by Darin Adler
Modified: 2019-02-06 09:02 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2012-06-10 10:50 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2012-06-10 10:47:55 PDT
Some additional tweaks to keep TreeShared code simple/clean
Comment 1 Darin Adler 2012-06-10 10:50:09 PDT
Created attachment 146745 [details]
Patch
Comment 2 Darin Adler 2012-06-10 10:50:44 PDT
Just a tiny tweak I missed when doing the last patch.
Comment 3 Kentaro Hara 2012-06-10 10:55:07 PDT
Comment on attachment 146745 [details]
Patch

Looks good to me. But I'd like to delegate the review to experts.
Comment 4 Adam Barth 2012-06-10 11:28:18 PDT
Comment on attachment 146745 [details]
Patch

Having a destructor be virtual or not based on NDEBUG sounds scary!  That can lead to behavior differences between Release and Debug that are hard to track down.
Comment 5 Darin Adler 2012-06-10 11:30:44 PDT
(In reply to comment #4)
> Having a destructor be virtual or not based on NDEBUG sounds scary!

Yes, fixing that was my main motivation for this patch. I was in the shower and thinking about that virtual keyword there and came back to my computer to do this patch.
Comment 6 WebKit Review Bot 2012-06-10 12:19:37 PDT
Comment on attachment 146745 [details]
Patch

Clearing flags on attachment: 146745

Committed r119943: <http://trac.webkit.org/changeset/119943>
Comment 7 WebKit Review Bot 2012-06-10 12:19:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Lucas Forschler 2019-02-06 09:02:49 PST
Mass moving XML DOM bugs to the "DOM" Component.