Bug 88723 - Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
Summary: Remove support for disconnected/excluded from search frames, they are not use...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 88758
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-09 20:55 PDT by Sam Weinig
Modified: 2012-09-14 00:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (15.11 KB, patch)
2012-06-09 21:03 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (22.91 KB, patch)
2012-06-10 20:27 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-06-09 20:55:18 PDT
Remove support for disconnected frames, they are not used by Safari anymore
Comment 1 Sam Weinig 2012-06-09 21:03:59 PDT
Created attachment 146722 [details]
Patch
Comment 2 mitz 2012-06-09 21:51:24 PDT
Comment on attachment 146722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146722&action=review

> Source/WebCore/editing/Editor.cpp:2417
> +bool Editor::insideVisibleArea(const LayoutPoint&) const

You should just remove this function.

> Source/WebCore/editing/Editor.cpp:2426
>  bool Editor::insideVisibleArea(Range* range) const

And this one.

> Source/WebKit/mac/WebView/WebFrame.mm:914
> +// FIXME: This is being kept around to avoid linking issues with the nightly,
> +// and should be removed when it is no longer needed

I think it is no longer needed.

> Source/WebKit/mac/WebView/WebFramePrivate.h:33
> +#import <JavaScriptCore/WebKitAvailability.h>

Why this?
Comment 3 Sam Weinig 2012-06-09 22:37:53 PDT
(In reply to comment #2)
> (From update of attachment 146722 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146722&action=review
> 
> > Source/WebCore/editing/Editor.cpp:2417
> > +bool Editor::insideVisibleArea(const LayoutPoint&) const
> 
> You should just remove this function.
> 
> > Source/WebCore/editing/Editor.cpp:2426
> >  bool Editor::insideVisibleArea(Range* range) const
> 
> And this one.

I was going to do it in a follow up where I remove the excludeTextFromSearch stuff, but I could do it now.

> 
> > Source/WebKit/mac/WebView/WebFrame.mm:914
> > +// FIXME: This is being kept around to avoid linking issues with the nightly,
> > +// and should be removed when it is no longer needed
> 
> I think it is no longer needed.

Ok.

> 
> > Source/WebKit/mac/WebView/WebFramePrivate.h:33
> > +#import <JavaScriptCore/WebKitAvailability.h>
> 
> Why this?

A mistake. I was going to use that for deprecating, but we don't need to deprecate.
Comment 4 Sam Weinig 2012-06-10 20:27:17 PDT
Created attachment 146768 [details]
Patch
Comment 5 Sam Weinig 2012-06-10 23:11:48 PDT
Committed r119955: <http://trac.webkit.org/changeset/119955>
Comment 6 WebKit Review Bot 2012-06-10 23:52:35 PDT
Re-opened since this is blocked by 88758
Comment 7 Pratik Solanki 2012-09-13 23:18:06 PDT
Isn't this fixed? This was relanded in r120005 - <http://trac.webkit.org/changeset/120005>.
Comment 8 Adam Barth 2012-09-14 00:18:24 PDT
Seems likely.