Bug 88721 – Compile error: 'bool std::isinf(float)' is not 'constexpr' with GCC 4.6 in C++11 mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Floris Bos]

Compile error:

==
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isinf(float)':
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:292:63: error: 'bool std::isinf(float)' is not 'constexpr'
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isinf(double)':
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:293:64: error: 'bool std::isinf(double)' is not 'constexpr'
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isnan(float)':
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:294:63: error: 'bool std::isnan(float)' is not 'constexpr'
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isnan(double)':
[...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:295:64: error: 'bool std::isnan(double)' is not 'constexpr'
==


Concerns the following code:

==
#if COMPILER_QUIRK(GCC11_GLOBAL_ISINF_ISNAN)
// A workaround to avoid conflicting declarations of isinf and isnan when compiling with GCC in C++11 mode.
namespace std {
    constexpr bool wtf_isinf(float f) { return std::isinf(f); }
    constexpr bool wtf_isinf(double d) { return std::isinf(d); }
    constexpr bool wtf_isnan(float f) { return std::isnan(f); }
    constexpr bool wtf_isnan(double d) { return std::isnan(d); }
};

using std::wtf_isinf;
using std::wtf_isnan;

#define isinf(x) wtf_isinf(x)
#define isnan(x) wtf_isnan(x)
#endif
==

Seems that with the gcc 4.6.3 the function std::isinf() is not marked constexpr, so wtf_isinf() may not be that either.
After replacing "constexpr" with "inline" it does compile.

[Allan Sandfeld Jensen]

(In reply to comment #0)
> Seems that with the gcc 4.6.3 the function std::isinf() is not marked constexpr, so wtf_isinf() may not be that either.
> After replacing "constexpr" with "inline" it does compile.

Ah, interesting. It should be harmless to replace constexpr with inline for gcc 4.7 as well.

[Allan Sandfeld Jensen]

(In reply to comment #1)
> (In reply to comment #0)
> > Seems that with the gcc 4.6.3 the function std::isinf() is not marked constexpr, so wtf_isinf() may not be that either.
> > After replacing "constexpr" with "inline" it does compile.
> 
> Ah, interesting. It should be harmless to replace constexpr with inline for gcc 4.7 as well.

I wouldn't call it regression though. C++11 mode was not work

[Alexey Proskuryakov]

*** Bug 89463 has been marked as a duplicate of this bug. ***

[Balazs Kelemen]

Created attachment 148531 [details]
Patch

[WebKit Review Bot]

Attachment 148531 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ma..." exit_code: 1
Source/WTF/wtf/MathExtras.h:285:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WTF/wtf/MathExtras.h:285:  wtf_isinf is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/MathExtras.h:286:  wtf_isinf is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/MathExtras.h:287:  wtf_isnan is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/MathExtras.h:288:  wtf_isnan is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Allan Sandfeld Jensen]

Comment on attachment 148531 [details]
Patch

LGTM

[Csaba Osztrogonác]

Comment on attachment 148531 [details]
Patch

LGTM, r=me.

[Balazs Kelemen]

Comment on attachment 148531 [details]
Patch

Clearing flags on attachment: 148531

Committed r120922: <http://trac.webkit.org/changeset/120922>

[Balazs Kelemen]

All reviewed patches have been landed.  Closing bug.