Bug 88718 - Make WebGL mark draws for compositing even if the draw count is zero
Summary: Make WebGL mark draws for compositing even if the draw count is zero
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-09 13:56 PDT by Gregg Tavares
Modified: 2012-06-11 15:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2012-06-09 13:58 PDT, Gregg Tavares
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-06-09 13:56:37 PDT
Make WebGL mark draws for compositing even if the draw count is zero
Comment 1 Gregg Tavares 2012-06-09 13:58:17 PDT
Created attachment 146717 [details]
Patch
Comment 2 Kenneth Russell 2012-06-09 22:51:03 PDT
Comment on attachment 146717 [details]
Patch

Looks fine. Is there any way we could adjust one of the pixel tests which uses requestAnimationFrame to verify this behavior? r=me in the meantime.
Comment 3 WebKit Review Bot 2012-06-09 23:36:43 PDT
Comment on attachment 146717 [details]
Patch

Clearing flags on attachment: 146717

Committed r119922: <http://trac.webkit.org/changeset/119922>
Comment 4 WebKit Review Bot 2012-06-09 23:36:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Gregg Tavares 2012-06-11 15:19:27 PDT
Unfortunately there's no way I know of to test this automatically

example of bug

clear canvas to green
wait for composite
at this point any read will be 0,0,0,0 but display will be green

draw with count of 0
at this point composite should show cleared canvas since the draw should have forced a composite but there's no way to test, at least not with layout tests. a screen capture could test this.

Put manual tests here for now.
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/manual/