Bug 88710 - Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise.
Summary: Web Inspector: Open links in Sources panel by default and fallback to Resourc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
: 88025 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-06-09 07:40 PDT by Vsevolod Vlasov
Modified: 2012-06-09 09:53 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2012-06-09 08:25 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-06-09 07:40:58 PDT
Patch to follow.
Comment 1 Vsevolod Vlasov 2012-06-09 08:25:00 PDT
Created attachment 146704 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-06-09 08:34:43 PDT
*** Bug 88025 has been marked as a duplicate of this bug. ***
Comment 3 Pavel Feldman 2012-06-09 09:40:14 PDT
Comment on attachment 146704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146704&action=review

> Source/WebCore/inspector/front-end/inspector.js:974
> +        preferredPanels.push(this.panels["scripts"]);

this.panels.scripts

> Source/WebCore/inspector/front-end/inspector.js:975
> +    if (this.panels["resources"])

Nit: we should remove the hiddenPanels altogether and get rid of these checks.

> Source/WebCore/inspector/front-end/inspector.js:976
> +        preferredPanels.push(this.panels["resources"]);

ditto

> Source/WebCore/inspector/front-end/inspector.js:978
> +        preferredPanels.push(this.panels["network"]);

ditto
Comment 4 Vsevolod Vlasov 2012-06-09 09:53:31 PDT
Committed r119906: <http://trac.webkit.org/changeset/119906>