Web Inspector: Support user attributes in DOMNode

[Alexander Pavlov (apavlov)]

This is needed for decorating DOM elements in the tree outline. It should be possible to determine if an element's children have a given user attribute defined, too.

[Alexander Pavlov (apavlov)]

Created attachment 147307 [details]
Patch

[Pavel Feldman]

Comment on attachment 147307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147307&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:707
> +    setUserAttribute: function(name, value)

setUserProperty ?

> Source/WebCore/inspector/front-end/DOMAgent.js:712
> +            var didHaveAttribute = this._userAttributes[name] !== null && this._userAttributes[name] !== undefined && this._userAttributes[name] !== false;

Lets clear on "null" only

> Source/WebCore/inspector/front-end/DOMAgent.js:718
> +        if (nowHaveAttribute)

This looks weird, I would extract "remove" method

> Source/WebCore/inspector/front-end/DOMAgent.js:731
> +        return this._descendantUserAttributeCounters && this._descendantUserAttributeCounters[name] ? this._descendantUserAttributeCounters[name] : 0;

I think this._descendantUserAttributeCounters can exist at all times.

[Alexander Pavlov (apavlov)]

Committed r120208: <http://trac.webkit.org/changeset/120208>