RESOLVED WONTFIX 88700
Fix RenderLayerCompositor::recursiveRepaintLayerRect to respect transform 
https://bugs.webkit.org/show_bug.cgi?id=88700
Summary Fix RenderLayerCompositor::recursiveRepaintLayerRect to respect transform
Tien-Ren Chen
Reported 2012-06-08 22:57:54 PDT
Fix RenderLayerCompositor::recursiveRepaintLayerRect to respect transform
Attachments
Patch (4.22 KB, patch)
2012-06-08 22:58 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tien-Ren Chen
Comment 1 2012-06-08 22:58:45 PDT
Created attachment 146686 [details] Patch
WebKit Review Bot
Comment 2 2012-06-08 23:02:34 PDT
Attachment 146686 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tien-Ren Chen
Comment 3 2012-06-08 23:05:42 PDT
This should fix the bug that text box carets doesn't blink in transformed elements. As I'll be OOO for 2 weeks, could aelias@ or jknotten@ help me finish the patch? Thanks!
Adam Barth
Comment 4 2012-07-27 01:59:20 PDT
@trchen: Is this patch still current?
Brent Fulgham
Comment 5 2012-11-20 13:52:30 PST
I would love to r+ this patch, but it's not clear what tests we would look at to confirm it was doing what was expected. Can you please update the ChangeLog with the relevant tests we should use for this change?
Tien-Ren Chen
Comment 6 2012-11-20 16:15:10 PST
(In reply to comment #5) > I would love to r+ this patch, but it's not clear what tests we would look at to confirm it was doing what was expected. > > Can you please update the ChangeLog with the relevant tests we should use for this change? Test is one issue... Another issue is the algorithmic complexity. The original code applies layer offset incrementally. It takes O(1) to enter a sub-tree. My patch re-runs the transformation chain when arriving every node, taking O(H) to enter a sub-tree at depth H. This makes tree traversal worse than O(H^2) I'd like to make this patch to do incremental transformation, but it needs to be very careful about fixed position elements. Hopefully we can make use some of the existing code. (RenderGeometryMap looks like what we need)
Tien-Ren Chen
Comment 7 2013-01-30 14:42:36 PST
The only user of this function is the caret, and now carets are container-aware. Planning to remove the function.
Note You need to log in before you can comment on or make changes to this bug.