Bug 88697 – Refactor WebGLFramebuffer to handle texture attachments

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Gregg Tavares]

Refactor WebGLFramebuffer to handle texture attachments

[Gregg Tavares]

Created attachment 146677 [details]
Patch

[Early Warning System Bot]

Comment on attachment 146677 [details]
Patch

Attachment 146677 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12922662

[Early Warning System Bot]

Comment on attachment 146677 [details]
Patch

Attachment 146677 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12922663

[Build Bot]

Comment on attachment 146677 [details]
Patch

Attachment 146677 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12936115

[Gregg Tavares]

Created attachment 146680 [details]
Patch

[WebKit Review Bot]

Comment on attachment 146680 [details]
Patch

Attachment 146680 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12923613

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

[WebKit Review Bot]

Created attachment 146689 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Zhenyao Mo]

LGTM

[Kenneth Russell]

Are the cr-linux LayoutTest failures related to this patch or unrelated?

[Gregg Tavares]

They appear to be unrelated.

I can upload the patch again, rebased, to see it run through the bots

[Gregg Tavares]

Created attachment 146963 [details]
Patch

[Gregg Tavares]

Created attachment 146966 [details]
Patch

[Gregg Tavares]

it's all green now

[Kenneth Russell]

Comment on attachment 146966 [details]
Patch

If it looks good to Mo it looks good to me. Thanks for investigating the layout test failures.

[WebKit Review Bot]

Comment on attachment 146966 [details]
Patch

Rejecting attachment 146966 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
git/webkit-commit-queue/Source/WebKit/chromium/ui --revision 141227 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 141227.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12943641

[Kenneth Russell]

Gregg, does it look to you like the conflict in the ChangeLog is real, or is the commit queue hosed? Maybe check with abarth on IRC...

[Gregg Tavares]

Created attachment 147188 [details]
Patch

[Gregg Tavares]

no idea. Here's a re-based patch

[Adrienne Walker]

Comment on attachment 147188 [details]
Patch

Rs=me, based on kbr's previous R+.

gman: If you get an R+ but you need to upload another patch, you can just changed the "Reviewed by NOBODY (OOPS!)." line to "Reviewed by Person Name." and then just set CQ? on the patch to have anybody commit it without needing an additional review.

[WebKit Review Bot]

Comment on attachment 147188 [details]
Patch

Clearing flags on attachment: 147188

Committed r120255: <http://trac.webkit.org/changeset/120255>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.