RESOLVED FIXED 88694
commit-queue flags in webkit-patch are confusing 
https://bugs.webkit.org/show_bug.cgi?id=88694
Summary commit-queue flags in webkit-patch are confusing
Dirk Pranke
Reported 2012-06-08 18:23:21 PDT
webkit-patch upload --request-commit 's help text says "Mark the patch as needing auto-commit after review". I'm not sure if this means cq? or cq+. Also, perhaps there should be a way to specify cq- ? (We default to None, which I think is correct). I'm not actually sure if there's a need for cq+, so maybe cq? is fine and we just need to update the help string?
Attachments
Patch (2.17 KB, patch)
2015-07-23 16:58 PDT, Dean Johnson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (806.90 KB, application/zip)
2015-07-23 17:19 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-06-08 19:34:38 PDT
I think we just need to update the help string. Also, can we add a short version of request-commit? -cq? -c? --cq?
Adam Barth
Comment 2 2012-06-09 11:41:07 PDT
"Request that the patch be added to the commit-queue once reviewed." ??
Dean Johnson
Comment 3 2015-07-23 16:58:53 PDT
Created attachment 257409 [details] Patch
Build Bot
Comment 4 2015-07-23 17:19:15 PDT
Comment on attachment 257409 [details] Patch Attachment 257409 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5322973896507392 New failing tests: svg/W3C-SVG-1.1/animate-elem-02-t.svg
Build Bot
Comment 5 2015-07-23 17:19:18 PDT
Created attachment 257412 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
WebKit Commit Bot
Comment 6 2015-07-24 01:05:12 PDT
Comment on attachment 257409 [details] Patch Clearing flags on attachment: 257409 Committed r187332: <http://trac.webkit.org/changeset/187332>
WebKit Commit Bot
Comment 7 2015-07-24 01:05:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.