Bug 88677 – [GTK] build accelerated compositing on by default if OpenGL is present

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

If OpenGL is present, we should build accelerated compositing on by default, just like WebGL. We also should improve the build script to be smarter about Clutter support (it should disable WebGL).

[Martin Robinson]

Created attachment 146620 [details]
Patch

[Alejandro G. Castro]

Comment on attachment 146620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146620&action=review

Looks good to me, just added some proposals.

> ChangeLog:9
> +        Also prevent enabling WebGL is Clutter is turned on.

nit: s/is/if/

> configure.ac:533
> +                           [Select accelerated backend (Clutter currently unsupported) [default=autodetect]]), [],

This message could be confusing because clutter is supported but no in the detection if I understand correctly.

> configure.ac:554
>      OPENGL_LIBS="-lGL -ldl"

Would it make sense to use PKG_CHECK_MODULES with gl?

> configure.ac:572
> +if test "$enable_webgl" = "yes" && test "$with_acceleration_backend" != "opengl"; then

Should we use '= "clutter"' better?

> configure.ac:1262
> +if test "$with_acceleration_backend" = "clutter"; then
>     PKG_CHECK_MODULES(CLUTTER, clutter-1.0 >= $CLUTTER_REQUIRED_VERSION)
>     PKG_CHECK_MODULES([CLUTTER_GTK],
>                       [clutter-gtk-1.0 >= $CLUTTER_GTK_REQUIRED_VERSION])

Isn't this if repeated?

[Martin Robinson]

Comment on attachment 146620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146620&action=review

>> configure.ac:533
>> +                           [Select accelerated backend (Clutter currently unsupported) [default=autodetect]]), [],
> 
> This message could be confusing because clutter is supported but no in the detection if I understand correctly.

Hrm. I guess I'll write "(Clutter currently unsupported, OpenGL will be autodetected)"

>> configure.ac:554
>>      OPENGL_LIBS="-lGL -ldl"
> 
> Would it make sense to use PKG_CHECK_MODULES with gl?

Mesa OpenGL doesn't ship with a pkgconfig files, sadly and some systems have funky proprietary drivers.

>> configure.ac:572
>> +if test "$enable_webgl" = "yes" && test "$with_acceleration_backend" != "opengl"; then
> 
> Should we use '= "clutter"' better?

I also want this to trigger for with_acceleration_backend = 'none'

>> configure.ac:1262
>>                       [clutter-gtk-1.0 >= $CLUTTER_GTK_REQUIRED_VERSION])
> 
> Isn't this if repeated?

Yes it is! I'll fix this up.

[Martin Robinson]

Committed r119869: <http://trac.webkit.org/changeset/119869>