Bug 88673 – REGRESSION: Cannot log in to webanketa.com

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: JavaScriptCore

[Maxim]

I can't log in into the site "webanketa.com" in normal mode with latest Safari 5.1.7
But if turn on debug mode, log in is successful. Looks like JS optimizations error. Similar problem was in Opera, when they are start to optimize JS code.

Under Windows this version Safari work without any problems.

[Alexey Proskuryakov]

Can you please explain what "debug mode" is? Are you saying that you can log in only with Web Inspector open?

Did you try WebKit nightly builds from <http://nightly.webkit.org/>?

[Maxim]

(In reply to comment #1)
> Can you please explain what "debug mode" is? Are you saying that you can log in only with Web Inspector open?
> 
> Did you try WebKit nightly builds from <http://nightly.webkit.org/>?

Yes, "debug mode" = "Show Web Inspector" / "Scripts" / "Enable Debugging". And yes, I can log in only in this mode.

I don't have access to MacOS system for testing => I can't test nightly build right now. It can take few days. Sorry. But if you can't repeat this problem and nightly build will be work under MacOS X 10.6, I'll test it.

thank you.

[Maxim]

With nightly build of WebKit r119961 still can't log in. (but can in debugging mode )

[Alexey Proskuryakov]

I can reproduce this.

[Alexey Proskuryakov]

<rdar://problem/11639508>

[Maxim]

similar reports:

https://discussions.apple.com/message/18001083#18001083

https://github.com/Caligatio/jsSHA/issues/3

5 month old bug with SHA-js libraries.
Any news about fix? :)

[Alexey Proskuryakov]

You could help by providing an isolated test case, as minimal as possible.

[Maxim]

(In reply to comment #7)
> You could help by providing an isolated test case, as minimal as possible.

Unfortunately I do not have access to Mac OS :( You can try to ask about it the authors of SHA-libraries. May be some one from them can help us?

[Maxim]

comment from one of jsSHA users:
I did a bunch of debugging as well, and found that the error seems to sit in the rotr_64 function. Its a stupid simple function, but it appears to be a 64/32 bit issue. Safari can only run in 64 bit mode now, but when run in 32 bit mode on older versions of OS X, reports are that it works as expected. I will leave that with you.

[Brian T]

jsSHA dev weighing in here

I just got contacted by a major company that happens to be a jsSHA reporting that iOS6 devices are also apparently having issues.  Unfortunately, much like Maxim, I don't have a 64-bit Mac device laying around to troubleshoot this on but I can tell you what OSes/Browsers *do* work:
 - Firefox on Win7 x64
 - Chrome on Win7 x64
 - IE9 on Win7 x64
 - IE9 x64 on Win7 x64
 - Firefox on Snow Leopard (32-bit)
 - Safari 5 on Snow Leopard (32-bit)
 - Chrome on Snow Leopard (32-bit)
 - Firefox on Linux x64
 - Chrome on Linux x64

I'm more than willing to commit time to helping solve this if someone can somehow donate time on an affected device.

[Maxim]

comment from one of jsSHA users:
I think I have found the problem. The rotr_64 function seems to mutate its argument. I do this:

rotr_64 = function (x, n) {
 x = new Int_64(x.highOrder, x.lowOrder);
 ...

and that seems to fix the problem.

[Maxim]

(In reply to comment #7)
> You could help by providing an isolated test case, as minimal as possible.

Looks like this is very hard task, because problem in JS optimizer. Any change of code fix this problem and can add another in another place.

Here one more comment of jsSHA users after test fix:
This is enough to fix the bug too:
  var foo = typeof x;

Or this:
  var foo = typeof n;

Or this:
  var foo = typeof 1;

...

Yes, the fix you pushed "works", but almost certainly not for the reason that you think it does. In particular, it has nothing to do with destructive changes to X, and it has nothing to do with undefined values in X. This is shown by the fact that you can "fix" the problem by adding (certain kinds of) dead code.

[Maxim]

(In reply to comment #7)
> You could help by providing an isolated test case, as minimal as possible.

http://www.flownet.com/ron/weird_bug.html
This page will output additional information when browser has problem.
Author: https://github.com/Caligatio/jsSHA/issues/3#issuecomment-10707633

[Alexey Proskuryakov]

> http://www.flownet.com/ron/weird_bug.html
> This page will output additional information when browser has problem.

This says "Dead code has not run" for me. Does it mean that the issue no longer occurs?

[Maxim]

(In reply to comment #14)
> Does it mean that the issue no longer occurs?

Dead code writed for "jsSHA" and this is just workaround - not a solution.
I use Paj's SHA-1 library ( http://pajhome.org.uk/crypt/md5/ ), which has no "Dead code" as workaround, and I can't test it on Mac :(
Need to test on Mac for confirm.

[Alexey Proskuryakov]

I have a Mac. What can I do to confirm whether the issue is fixed? The web site works, and the test provided in comment 13 is unclear to me.

[Maxim]

(In reply to comment #16)
> I have a Mac. What can I do to confirm whether the issue is fixed? The web site works, and the test provided in comment 13 is unclear to me.

If you can login into webanketa.com and test script output "Dead code has not run" - looks like problem was fixed. What version of Safari do you use?

[Alexey Proskuryakov]

Safari 6.0.2 on OS X 10.8.2.