Bug 88668 - [chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized
Summary: [chromium] Single thread proxy's animation timer should short circuit if the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: vollick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-08 10:36 PDT by vollick
Modified: 2012-06-08 19:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (71.07 KB, patch)
2012-06-08 10:46 PDT, vollick
no flags Details | Formatted Diff | Diff
Patch (71.05 KB, patch)
2012-06-08 12:06 PDT, vollick
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vollick 2012-06-08 10:36:40 PDT
It can currently happen that the single thread proxy's animation timer can fire before initialization starts. We should early out in this case.
Comment 1 vollick 2012-06-08 10:46:33 PDT
Created attachment 146603 [details]
Patch

This ended up being a 2 line change, but the testing required some more work.
Rather than adding yet more tests to CCLayerTreeHostTest that don't belong
there, I refactored the code required for running threaded tests into
CCThreadedTest.h/cpp, added a CCSingleThreadProxyTest.cpp and moved the proxy-
related tests into that file. This will allow us to more easily create new tests
that require simulating the threaded environment.
Comment 2 vollick 2012-06-08 12:06:42 PDT
Created attachment 146623 [details]
Patch

Sorry for the spam. Making clang happy.
Comment 3 James Robinson 2012-06-08 12:51:32 PDT
Comment on attachment 146623 [details]
Patch

OMG Proxy tests yay!

R=me.
Comment 4 WebKit Review Bot 2012-06-08 19:26:53 PDT
Comment on attachment 146623 [details]
Patch

Clearing flags on attachment: 146623

Committed r119886: <http://trac.webkit.org/changeset/119886>
Comment 5 WebKit Review Bot 2012-06-08 19:26:56 PDT
All reviewed patches have been landed.  Closing bug.