Bug 88661 - [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
Summary: [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing aft...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-08 09:03 PDT by Sudarsana Nagineni (babu)
Modified: 2012-06-11 12:45 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2012-06-08 09:18 PDT, Sudarsana Nagineni (babu)
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2012-06-10 10:18 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2012-06-10 23:58 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-06-08 09:03:33 PDT
The following tests started failing after r119788. 

fast/dom/frame-loading-via-document-write.html = TEXT
http/tests/security/frame-loading-via-document-write.html = TEXT
http/tests/security/local-JavaScript-from-remote.html = TEXT
http/tests/security/local-iFrame-from-remote.html = TEXT

It seems we are constructing a String object from non-null-terminated UChar* returned by characters() and that is causing the issue.

http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp#L181
Comment 1 Sudarsana Nagineni (babu) 2012-06-08 09:18:21 PDT
Created attachment 146585 [details]
Patch

Pass string length explicitly when creating String object from non-null-terminated UChar* returned by characters().
Comment 2 Chris Dumez 2012-06-08 09:19:21 PDT
Comment on attachment 146585 [details]
Patch

LGTM.
Comment 3 Joshua Lock (joshuagl) 2012-06-08 09:31:51 PDT
I was just about to submit the same change, thanks.
Comment 4 Gyuyoung Kim 2012-06-09 04:25:17 PDT
Comment on attachment 146585 [details]
Patch

Looks fine.
Comment 5 Chris Dumez 2012-06-09 10:47:39 PDT
Skipping those tests in Bug 88714 to make the tree green. Please don't forget to unskip the tests.
Comment 6 Chris Dumez 2012-06-09 11:54:06 PDT
Comment on attachment 146585 [details]
Patch

Setting cq- because the patch at Bug 88714 has landed. Please update the patch and unskip the test cases before landing. Thanks.
Comment 7 Sudarsana Nagineni (babu) 2012-06-10 10:06:31 PDT
(In reply to comment #6)
> Setting cq- because the patch at Bug 88714 has landed. Please update the patch and unskip the test cases before landing. Thanks.

Cool. I will unskip those test cases.
Comment 8 Sudarsana Nagineni (babu) 2012-06-10 10:18:11 PDT
Created attachment 146743 [details]
Patch

Fixed issue in pathToLocalResource() and unskipped test cases.
Comment 9 Chris Dumez 2012-06-10 10:19:59 PDT
Comment on attachment 146743 [details]
Patch

Perfect, thanks!
Comment 10 Sudarsana Nagineni (babu) 2012-06-10 23:58:04 PDT
Created attachment 146794 [details]
Patch

rebased.
Comment 11 WebKit Review Bot 2012-06-11 12:45:36 PDT
Comment on attachment 146794 [details]
Patch

Clearing flags on attachment: 146794

Committed r119998: <http://trac.webkit.org/changeset/119998>
Comment 12 WebKit Review Bot 2012-06-11 12:45:43 PDT
All reviewed patches have been landed.  Closing bug.