Bug 88644 – Using BlobBuilder should show a deprecation warning message (if it is enabled)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kinuko Yasuda]

Using BlobBuilder should show a deprecation warning message.

Mac has already disabled BlobBuilder, but Chrome is keeping it since it has been while since it has shipped it.
FireFox starts showing a warning after Firefox 14.

We should start showing deprecation warning message on Chromium (or on any platforms that enables BlobBuilder).

[Kinuko Yasuda]

Created attachment 146536 [details]
Patch

[Kinuko Yasuda]

Created attachment 146537 [details]
Patch

[WebKit Review Bot]

Comment on attachment 146537 [details]
Patch

Attachment 146537 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12921512

New failing tests:
fast/filesystem/file-metadata-after-write.html

[WebKit Review Bot]

Created attachment 146550 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Kinuko Yasuda]

Created attachment 146561 [details]
Patch

[Jian Li]

Comment on attachment 146561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146561&action=review

> Source/WebCore/ChangeLog:9
> +        We should start showing a warning to let people migrate to use Blob constructor.

nit: migrate to using

> Source/WebCore/fileapi/WebKitBlobBuilder.h:48
> +    // Special constructor for binding which shows deprecate warning before calling the real constructor.

Probably better to add comment for both static creators to illustrate that they're called in different scenarios.
For this one, consider something like:
  // Called when BlobBuilder is instantiated in JS API. We show deprecate warning message.
For next one, consider something like:
  // Called by Blob constructor ...

[Kinuko Yasuda]

Committed r119956: <http://trac.webkit.org/changeset/119956>