Bug 88642 – [BlackBerry] Wrong mimetype for empty file link

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Mary Wu]

For empty file link, we shouldn't give "application/octet-stream" which will lead to download.

[Mary Wu]

Created attachment 146534 [details]
Patch

[Rob Buis]

Comment on attachment 146534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146534&action=review

Change is correct but might be able to clean it up.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625
> +        mimeType = "text/plain";

It seems like you can change the if if if if to if else if else sections. What do you think? This avoids testing for isNull() when you already know the outcome based on the previous statement/assignment.

[Mary Wu]

(In reply to comment #2)
> (From update of attachment 146534 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146534&action=review
> 
> Change is correct but might be able to clean it up.
> 
> > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625
> > +        mimeType = "text/plain";
> 
> It seems like you can change the if if if if to if else if else sections. What do you think? This avoids testing for isNull() when you already know the outcome based on the previous statement/assignment.

yes, could add else if some place.

[Mary Wu]

Created attachment 146764 [details]
Patch

[Rob Buis]

Comment on attachment 146764 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 146764 [details]
Patch

Clearing flags on attachment: 146764

Committed r120035: <http://trac.webkit.org/changeset/120035>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.