Bug 88626 - Add app_abi option for DumpRenderTree_apk
Summary: Add app_abi option for DumpRenderTree_apk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Wei James (wistoch)
URL:
Keywords:
Depends on:
Blocks: 88658
  Show dependency treegraph
 
Reported: 2012-06-07 23:30 PDT by Wei James (wistoch)
Modified: 2012-06-08 11:44 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2012-06-07 23:30 PDT, Wei James (wistoch)
no flags Details | Formatted Diff | Diff
Patch (1.35 KB, patch)
2012-06-08 08:33 PDT, Wei James (wistoch)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wei James (wistoch) 2012-06-07 23:30:30 PDT
Add app_abi option for DumpRenderTree_apk
Comment 1 Wei James (wistoch) 2012-06-07 23:30:58 PDT
Created attachment 146489 [details]
Patch
Comment 2 Peter Beverloo 2012-06-08 07:59:19 PDT
Comment on attachment 146489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review

LGTM from for Android's perspective, but please wait for a reviewer before submitting.

Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work!

> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443
> +                        '--app_abi=<(android_app_abi)'

One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines.

- '--app_abi=<(android_app_abi)'
+ '--app_abi',
+ '<(android_app_abi)',
Comment 3 Wei James (wistoch) 2012-06-08 08:33:46 PDT
Created attachment 146577 [details]
Patch
Comment 4 Wei James (wistoch) 2012-06-08 08:35:29 PDT
Comment on attachment 146489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review

>> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443
>> +                        '--app_abi=<(android_app_abi)'
> 
> One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines.
> 
> - '--app_abi=<(android_app_abi)'
> + '--app_abi',
> + '<(android_app_abi)',

fixed.thanks for the reviewing.
Comment 5 Wei James (wistoch) 2012-06-08 08:37:37 PDT
(In reply to comment #2)
> Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work!
> 

Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs.
Comment 6 Peter Beverloo 2012-06-08 08:45:29 PDT
(In reply to comment #5)
> Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs.

It'd be good for the general overview. Thank you very much!

LGTM. Could a reviewer have a formal look, please?
Comment 7 Adam Barth 2012-06-08 11:31:49 PDT
Comment on attachment 146577 [details]
Patch

rs=me
Comment 8 WebKit Review Bot 2012-06-08 11:44:54 PDT
Comment on attachment 146577 [details]
Patch

Clearing flags on attachment: 146577

Committed r119851: <http://trac.webkit.org/changeset/119851>
Comment 9 WebKit Review Bot 2012-06-08 11:44:59 PDT
All reviewed patches have been landed.  Closing bug.