Add app_abi option for DumpRenderTree_apk
Created attachment 146489 [details] Patch
Comment on attachment 146489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review LGTM from for Android's perspective, but please wait for a reviewer before submitting. Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work! > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443 > + '--app_abi=<(android_app_abi)' One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines. - '--app_abi=<(android_app_abi)' + '--app_abi', + '<(android_app_abi)',
Created attachment 146577 [details] Patch
Comment on attachment 146489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review >> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443 >> + '--app_abi=<(android_app_abi)' > > One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines. > > - '--app_abi=<(android_app_abi)' > + '--app_abi', > + '<(android_app_abi)', fixed.thanks for the reviewing.
(In reply to comment #2) > Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work! > Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs.
(In reply to comment #5) > Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs. It'd be good for the general overview. Thank you very much! LGTM. Could a reviewer have a formal look, please?
Comment on attachment 146577 [details] Patch rs=me
Comment on attachment 146577 [details] Patch Clearing flags on attachment: 146577 Committed r119851: <http://trac.webkit.org/changeset/119851>
All reviewed patches have been landed. Closing bug.