RESOLVED FIXED Bug 88624
WebAudio tests need to set WebKitWebAudioEnabled. 
https://bugs.webkit.org/show_bug.cgi?id=88624
Summary WebAudio tests need to set WebKitWebAudioEnabled.
Dongwoo Joshua Im (dwim)
Reported 2012-06-07 22:49:44 PDT
I will add one line of code below into the test cases of the WebAudio layouttest. "layoutTestController.overridePreference("WebKitWebAudioEnabled", "1");" Some tests have now, the others don't.
Attachments
Patch (2.51 KB, patch)
2012-06-08 00:45 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2012-06-10 17:00 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
Patch (1.78 KB, patch)
2012-06-10 17:14 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
Patch (9.22 KB, patch)
2012-06-10 21:37 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dongwoo Joshua Im (dwim)
Comment 1 2012-06-08 00:45:52 PDT
Created attachment 146499 [details] Patch Three tests don't have that.
Philippe Normand
Comment 2 2012-06-08 09:57:01 PDT
Comment on attachment 146499 [details] Patch Can you instead put this call in javascriptaudionode-testing.js? It seems those 3 tests include that file. The change would be similar to the one previously did for the tests using audio-testing.js
Dongwoo Joshua Im (dwim)
Comment 3 2012-06-08 18:46:54 PDT
(In reply to comment #2) > (From update of attachment 146499 [details]) > Can you instead put this call in javascriptaudionode-testing.js? It seems those 3 tests include that file. The change would be similar to the one previously did for the tests using audio-testing.js Yes, they do include that file. I will do it. ;)
Dongwoo Joshua Im (dwim)
Comment 4 2012-06-10 17:00:31 PDT
Created attachment 146757 [details] Patch I've fixed the patch regarding Philippe's comment.
Dongwoo Joshua Im (dwim)
Comment 5 2012-06-10 17:11:29 PDT
(In reply to comment #2) > (From update of attachment 146499 [details]) > Can you instead put this call in javascriptaudionode-testing.js? It seems those 3 tests include that file. The change would be similar to the one previously did for the tests using audio-testing.js Oh.. audiochannelmerger-basic.html is not include 'javascriptaudionode-testing.js' file. I will directly set the flag in the audiochannelmerger-basic.html.
Dongwoo Joshua Im (dwim)
Comment 6 2012-06-10 17:14:20 PDT
Created attachment 146759 [details] Patch
Chris Rogers
Comment 7 2012-06-10 20:08:35 PDT
Can't we just make sure that these tests "include" audio-testing.js? It seems unfortunate to have to add the overridePreference stuff into individual test files....
Dongwoo Joshua Im (dwim)
Comment 8 2012-06-10 20:11:34 PDT
(In reply to comment #7) > Can't we just make sure that these tests "include" audio-testing.js? > > It seems unfortunate to have to add the overridePreference stuff into individual test files.... Do you want all of the webaudio test cases include the 'audio-testing.js' file? I think it could be a good solution.
Chris Rogers
Comment 9 2012-06-10 21:21:26 PDT
(In reply to comment #8) > (In reply to comment #7) > > Can't we just make sure that these tests "include" audio-testing.js? > > > > It seems unfortunate to have to add the overridePreference stuff into individual test files.... > > Do you want all of the webaudio test cases include the 'audio-testing.js' file? > I think it could be a good solution. Seems better than having to add overridePreference to them all.
Dongwoo Joshua Im (dwim)
Comment 10 2012-06-10 21:37:12 PDT
Created attachment 146778 [details] Patch Dear Chris, Is this what you want? :)
WebKit Review Bot
Comment 11 2012-06-11 15:05:53 PDT
Comment on attachment 146778 [details] Patch Clearing flags on attachment: 146778 Committed r120011: <http://trac.webkit.org/changeset/120011>
WebKit Review Bot
Comment 12 2012-06-11 15:05:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.