I will add one line of code below into the test cases of the WebAudio layouttest. "layoutTestController.overridePreference("WebKitWebAudioEnabled", "1");" Some tests have now, the others don't.
Created attachment 146499 [details] Patch Three tests don't have that.
Comment on attachment 146499 [details] Patch Can you instead put this call in javascriptaudionode-testing.js? It seems those 3 tests include that file. The change would be similar to the one previously did for the tests using audio-testing.js
(In reply to comment #2) > (From update of attachment 146499 [details]) > Can you instead put this call in javascriptaudionode-testing.js? It seems those 3 tests include that file. The change would be similar to the one previously did for the tests using audio-testing.js Yes, they do include that file. I will do it. ;)
Created attachment 146757 [details] Patch I've fixed the patch regarding Philippe's comment.
(In reply to comment #2) > (From update of attachment 146499 [details]) > Can you instead put this call in javascriptaudionode-testing.js? It seems those 3 tests include that file. The change would be similar to the one previously did for the tests using audio-testing.js Oh.. audiochannelmerger-basic.html is not include 'javascriptaudionode-testing.js' file. I will directly set the flag in the audiochannelmerger-basic.html.
Created attachment 146759 [details] Patch
Can't we just make sure that these tests "include" audio-testing.js? It seems unfortunate to have to add the overridePreference stuff into individual test files....
(In reply to comment #7) > Can't we just make sure that these tests "include" audio-testing.js? > > It seems unfortunate to have to add the overridePreference stuff into individual test files.... Do you want all of the webaudio test cases include the 'audio-testing.js' file? I think it could be a good solution.
(In reply to comment #8) > (In reply to comment #7) > > Can't we just make sure that these tests "include" audio-testing.js? > > > > It seems unfortunate to have to add the overridePreference stuff into individual test files.... > > Do you want all of the webaudio test cases include the 'audio-testing.js' file? > I think it could be a good solution. Seems better than having to add overridePreference to them all.
Created attachment 146778 [details] Patch Dear Chris, Is this what you want? :)
Comment on attachment 146778 [details] Patch Clearing flags on attachment: 146778 Committed r120011: <http://trac.webkit.org/changeset/120011>
All reviewed patches have been landed. Closing bug.