Bug 88614 – Use CUSTOM_SCHEME_HANDLER flag rather than REGISTER_PROTOCOL_HANDLER.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore Misc.

[Dongwoo Joshua Im (dwim)]

Now, two new APIs are added into the Custom Scheme Handler spec,
and I implemented those functions in WebCore behind the CUSTOM_SCHEME_HANDLER flag.

How about use only CUSTOM_SCHEME_HANDLER rather than use both flags?

I think I can move 'registerProtocolHandler' function behind the CUSTOM_SCHEME_HANDLER flag.

[Dongwoo Joshua Im (dwim)]

If everyone feels ok about this,
I will make the patch.

[Dongwoo Joshua Im (dwim)]

Created attachment 146531 [details]
WIP Patch

Patch would be look like this WIP patch.

[Dongwoo Joshua Im (dwim)]

Created attachment 146532 [details]
WIP Patch

To make it easy to look at the WIP patch,
I upload this as a "patch".

I believe one of ews will deny this "WIP" patch.

[Gyuyoung Kim]

Comment on attachment 146532 [details]
WIP Patch

Attachment 146532 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12921543

[WebKit Review Bot]

Comment on attachment 146532 [details]
WIP Patch

Attachment 146532 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12922535

New failing tests:
fast/dom/register-protocol-handler.html
fast/dom/navigator-detached-no-crash.html

[WebKit Review Bot]

Created attachment 146588 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dongwoo Joshua Im (dwim)]

Created attachment 147758 [details]
Patch

[WebKit Review Bot]

Attachment 147758 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:222:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 2 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dongwoo Joshua Im (dwim)]

Created attachment 147761 [details]
Patch

[WebKit Review Bot]

Attachment 147761 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dongwoo Joshua Im (dwim)]

Created attachment 147764 [details]
Patch

[Adam Barth]

Comment on attachment 147764 [details]
Patch

As discussed on webkit-dev, Chromium currently sets these flags to different values.  Please don't combine them until everyone sets them to the same value as each other.