Bug 88594 – DFG should inline prototype chain accesses, and do the right things if the specific function optimization is available

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 146419 [details]
the patch

[WebKit Review Bot]

Attachment 146419 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecode/GetByIdStatus.h:41:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/bytecode/GetByIdStatus.h:84:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gavin Barraclough]

Comment on attachment 146419 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146419&action=review

> Source/JavaScriptCore/bytecode/GetByIdStatus.cpp:67
> +    UNUSED_PARAM(structure);

Oh yes they are!

[Filip Pizlo]

Created attachment 146423 [details]
patch with Gavin's suggestions

Putting up for EWS while I test it more.

[WebKit Review Bot]

Attachment 146423 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecode/GetByIdStatus.h:41:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Landed with some additional fixes in http://trac.webkit.org/changeset/119779

[Alexey Proskuryakov]

This caused bug 88783.