WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
88590
Style build architectures like build versions for non-layout test failures
https://bugs.webkit.org/show_bug.cgi?id=88590
Summary
Style build architectures like build versions for non-layout test failures
Ojan Vafai
Reported
2012-06-07 16:27:14 PDT
Style build architectures like build versions for non-layout test failures
Attachments
Patch
(1.67 KB, patch)
2012-06-07 16:27 PDT
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2012-06-07 16:27:59 PDT
Created
attachment 146412
[details]
Patch
Tony Chang
Comment 2
2012-06-07 16:29:57 PDT
Comment on
attachment 146412
[details]
Patch Why is the indenting in this file crazy?
Ojan Vafai
Comment 3
2012-06-07 16:37:53 PDT
(In reply to
comment #2
)
> (From update of
attachment 146412
[details]
) > Why is the indenting in this file crazy?
It's trying to be clever with grouping for showing descendant relationships. I'm not a huge fan, but my change is consistent with it, e.g. .parent { } .parent .child { } .parent .child:hover { }
Adam Barth
Comment 4
2012-06-07 17:17:12 PDT
> Why is the indenting in this file crazy?
It's dglazkov-style! If you think it's crazy, please feel free to make it non-crazy.
WebKit Review Bot
Comment 5
2012-06-07 19:19:47 PDT
Comment on
attachment 146412
[details]
Patch Clearing flags on attachment: 146412 Committed
r119784
: <
http://trac.webkit.org/changeset/119784
>
WebKit Review Bot
Comment 6
2012-06-07 19:19:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug