Bug 88590 - Style build architectures like build versions for non-layout test failures
Summary: Style build architectures like build versions for non-layout test failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 16:27 PDT by Ojan Vafai
Modified: 2012-06-07 19:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2012-06-07 16:27 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-06-07 16:27:14 PDT
Style build architectures like build versions for non-layout test failures
Comment 1 Ojan Vafai 2012-06-07 16:27:59 PDT
Created attachment 146412 [details]
Patch
Comment 2 Tony Chang 2012-06-07 16:29:57 PDT
Comment on attachment 146412 [details]
Patch

Why is the indenting in this file crazy?
Comment 3 Ojan Vafai 2012-06-07 16:37:53 PDT
(In reply to comment #2)
> (From update of attachment 146412 [details])
> Why is the indenting in this file crazy?

It's trying to be clever with grouping for showing descendant relationships. I'm not a huge fan, but my change is consistent with it, e.g.

.parent {
}
  .parent .child {
  }
  .parent .child:hover {
  }
Comment 4 Adam Barth 2012-06-07 17:17:12 PDT
> Why is the indenting in this file crazy?

It's dglazkov-style!

If you think it's crazy, please feel free to make it non-crazy.
Comment 5 WebKit Review Bot 2012-06-07 19:19:47 PDT
Comment on attachment 146412 [details]
Patch

Clearing flags on attachment: 146412

Committed r119784: <http://trac.webkit.org/changeset/119784>
Comment 6 WebKit Review Bot 2012-06-07 19:19:52 PDT
All reviewed patches have been landed.  Closing bug.