Bug 88576 - [BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One.
Summary: [BlackBerry] Should Use the WebPage Already Created by Client, No Need to Cre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 14:26 PDT by Crystal Zhang
Modified: 2012-06-07 17:00 PDT (History)
2 users (show)

See Also:


Attachments
patch (9.04 KB, patch)
2012-06-07 14:40 PDT, Crystal Zhang
rwlbuis: review-
Details | Formatted Diff | Diff
updated patch (9.41 KB, patch)
2012-06-07 15:10 PDT, Crystal Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Crystal Zhang 2012-06-07 14:26:35 PDT
When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use this to load popup, no need to create our own one.
The old code is based on an old solution which has been abandoned.
Comment 1 Crystal Zhang 2012-06-07 14:40:12 PDT
Created attachment 146392 [details]
patch
Comment 2 Rob Buis 2012-06-07 14:50:47 PDT
Comment on attachment 146392 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146392&action=review

Found one tiny cleanup possibility. Crystal will have a look whether more changes are needed.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:-312
> -        webPopup->closeWebPage();

You can remove the { and } now.
Comment 3 Crystal Zhang 2012-06-07 15:10:04 PDT
Created attachment 146397 [details]
updated patch
Comment 4 Rob Buis 2012-06-07 15:19:04 PDT
Comment on attachment 146397 [details]
updated patch

LGTM.
Comment 5 WebKit Review Bot 2012-06-07 17:00:23 PDT
Comment on attachment 146397 [details]
updated patch

Clearing flags on attachment: 146397

Committed r119774: <http://trac.webkit.org/changeset/119774>
Comment 6 WebKit Review Bot 2012-06-07 17:00:28 PDT
All reviewed patches have been landed.  Closing bug.