When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use this to load popup, no need to create our own one. The old code is based on an old solution which has been abandoned.
Created attachment 146392 [details] patch
Comment on attachment 146392 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=146392&action=review Found one tiny cleanup possibility. Crystal will have a look whether more changes are needed. > Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:-312 > - webPopup->closeWebPage(); You can remove the { and } now.
Created attachment 146397 [details] updated patch
Comment on attachment 146397 [details] updated patch LGTM.
Comment on attachment 146397 [details] updated patch Clearing flags on attachment: 146397 Committed r119774: <http://trac.webkit.org/changeset/119774>
All reviewed patches have been landed. Closing bug.