RESOLVED FIXED Bug 88575
[chromium] Allow LayoutTests under new git workflow 
https://bugs.webkit.org/show_bug.cgi?id=88575
Summary [chromium] Allow LayoutTests under new git workflow
Tony Payne
Reported 2012-06-07 14:05:05 PDT
[chromium] Allow LayoutTests under new git workflow
Attachments
Patch (22.13 KB, patch)
2012-06-07 14:07 PDT, Tony Payne 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Payne
Comment 1 2012-06-07 14:07:14 PDT
Created attachment 146387 [details] Patch
Dirk Pranke
Comment 2 2012-06-07 16:33:06 PDT
Comment on attachment 146387 [details] Patch this seems like a goofy way to figure out if you need to use .bat files, but that's not your fault. At some point this should get pushed into the classes directly.
Tony Payne
Comment 3 2012-06-07 16:40:15 PDT
(In reply to comment #2) > (From update of attachment 146387 [details]) > this seems like a goofy way to figure out if you need to use .bat files, but that's not your fault. At some point this should get pushed into the classes directly. Goofy? But it's got *awesome* right in the name! I agree, this is odd, but I'd like to be able to run the tests. Okay, newbie question time. This is my first r+ (woot!!).... how do I submit?
Dirk Pranke
Comment 4 2012-06-07 16:43:21 PDT
since you're not yet a committer, you need to get someone who is to either land it for you or mark it as cq+. If you wish that to happen, the convention is to set the cq? flag and then the reviewer will usually set cq+ at the same time as r+. But, I can land it for you as well if you like. (since I collided with you setting cq+, I can see you figured that out :).
WebKit Review Bot
Comment 5 2012-06-07 19:41:12 PDT
Comment on attachment 146387 [details] Patch Clearing flags on attachment: 146387 Committed r119785: <http://trac.webkit.org/changeset/119785>
WebKit Review Bot
Comment 6 2012-06-07 19:41:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.