Bug 88573 - Fix recent null pointer error regression in the flakiness dashboard
Summary: Fix recent null pointer error regression in the flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 13:43 PDT by Ojan Vafai
Modified: 2012-06-07 14:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.68 KB, patch)
2012-06-07 13:43 PDT, Ojan Vafai
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-06-07 13:43:27 PDT
Fix recent null pointer error regression in the flakiness dashboard
Comment 1 Ojan Vafai 2012-06-07 13:43:57 PDT
Created attachment 146377 [details]
Patch
Comment 2 Dirk Pranke 2012-06-07 13:49:56 PDT
Comment on attachment 146377 [details]
Patch

looks fine to me, but my JS-fu isn't terribly strong. Is it possible for something in the test to throw an exception that would cause doXHR not to be reassigned back to oldDoXHR? i.e. does that need to wrapped in a try/finally like you would in python?
Comment 3 Ojan Vafai 2012-06-07 13:58:51 PDT
(In reply to comment #2)
> (From update of attachment 146377 [details])
> looks fine to me, but my JS-fu isn't terribly strong. Is it possible for something in the test to throw an exception that would cause doXHR not to be reassigned back to oldDoXHR? i.e. does that need to wrapped in a try/finally like you would in python?

yes. good idea.
Comment 4 Ojan Vafai 2012-06-07 14:32:43 PDT
Committed r119754: <http://trac.webkit.org/changeset/119754>