Bug 88563 - [BlackBerry] Show correct fullscreen button image (media controls)
Summary: [BlackBerry] Show correct fullscreen button image (media controls)
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Max Feil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 11:39 PDT by Max Feil
Modified: 2012-11-02 12:43 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.56 KB, patch)
2012-06-07 11:46 PDT, Max Feil
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Feil 2012-06-07 11:39:35 PDT
The "enter" fullscreen button image is currently being rendered all the time. This needs to be changed so that the "exit" fullscreen button image is rendered when the video is fullscreen. PR159306
Comment 1 Max Feil 2012-06-07 11:46:08 PDT
Created attachment 146343 [details]
Patch
Comment 2 Antonio Gomes 2012-06-07 19:57:31 PDT
Comment on attachment 146343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146343&action=review

> Source/WebCore/ChangeLog:15
> +        I am not providing a test due to the simplicity of this patch
> +        and the relative difficulty and maintainability issues associated
> +        with testing how an image is rendered.
> +

I am not in love with this justification, but it is ok to go without a test for this case :)
Comment 3 WebKit Review Bot 2012-06-07 20:06:40 PDT
Comment on attachment 146343 [details]
Patch

Clearing flags on attachment: 146343

Committed r119789: <http://trac.webkit.org/changeset/119789>
Comment 4 WebKit Review Bot 2012-06-07 20:06:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Max Feil 2012-11-02 12:43:57 PDT
Closing bug for patch that landed a long time ago.