Bug 88551 – run-webkit-tests --lint-test-files gives an error when run on linux

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ojan Vafai]

$ run-webkit-tests --lint-test-files
Traceback (most recent call last):
  File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 454, in <module>
    sys.exit(main())
  File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 449, in main
    return run(port, options, args)
  File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 95, in run
    return lint(port, options)
  File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 65, in lint
    test_expectations.TestExpectations(port_to_lint, is_lint_mode=True)
  File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 732, in __init__
    self._expectations = self._parser.parse(port.test_expectations())
  File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium.py", line 319, in test_expectations
    return self._filesystem.read_text_file(expectations_path)
  File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 218, in read_text_file
    with codecs.open(path, 'r', 'utf8') as f:
  File "/usr/lib/python2.6/codecs.py", line 870, in open
    file = __builtin__.open(filename, mode, buffering)
IOError: [Errno 2] No such file or directory: '/media/src/chromium/src/third_party/WebKit/LayoutTests/platform/google-chrome-linux32/TestExpectations'
Failed to execute Tools/Scripts/new-run-webkit-tests at /work/chromium/src/third_party/WebKit/Tools/Scripts/run-webkit-tests line 122.

It works fine if I pass --platform=chromium-linux though. So, this isn't blocking me gardening or anything.

[Tony Chang]

I think we should just remove the google-chrome support from NRWT.  When it was added, I was under the impression that someone (the release managers?) would check in results on the branch.  In practice, they just suppress failures in TestExpectations.

[Dirk Pranke]

(In reply to comment #1)
> I think we should just remove the google-chrome support from NRWT.  When it was added, I was under the impression that someone (the release managers?) would check in results on the branch.  In practice, they just suppress failures in TestExpectations.

I agree, now that we can pass in additional expectation files on the command line, it should just be a matter of updating the bots to pass in the right command line flags and then we can remove this.

That, however, is not the problem here. rniwa's renaming of test_expectations.txt -> TestExpectations didn't handle these ports properly. Patch momentarily.

[Dirk Pranke]

Created attachment 146361 [details]
Patch

[Dirk Pranke]

Committed r119747: <http://trac.webkit.org/changeset/119747>