Bug 88533 - [Chromium] features.gypi should have the correct definitions for Android
Summary: [Chromium] features.gypi should have the correct definitions for Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on: 88564 88636 88637
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-06-07 06:58 PDT by Peter Beverloo
Modified: 2012-06-08 02:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.57 KB, patch)
2012-06-07 07:06 PDT, Peter Beverloo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-06-07 06:58:53 PDT 
[Chromium] features.gypi should have the correct definitions for Android
Comment 1 Peter Beverloo 2012-06-07 07:06:51 PDT 
Created attachment 146282 [details]
Patch
Comment 2 Peter Beverloo 2012-06-07 08:00:58 PDT 
Comment on attachment 146282 [details]
Patch

Confirmed that this doesn't break the Android build. It's a no-op for other platforms.
Comment 3 WebKit Review Bot 2012-06-07 11:04:26 PDT 
Comment on attachment 146282 [details]
Patch

Rejecting attachment 146282 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 WebCore::EUpdateLayout) const':
Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1358: error: enumeration value 'CSSPropertyWebkitOverflowScrolling' not handled in switch
  CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSFontFace.o
  CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSFontFaceRule.o
make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSComputedStyleDeclaration.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/12923059
Comment 4 Peter Beverloo 2012-06-07 11:50:11 PDT 
Comment on attachment 146282 [details]
Patch

Fixed that issue in r119743.
Comment 5 WebKit Review Bot 2012-06-07 13:08:21 PDT 
Comment on attachment 146282 [details]
Patch

Clearing flags on attachment: 146282

Committed r119749: <http://trac.webkit.org/changeset/119749>
Comment 6 WebKit Review Bot 2012-06-07 13:08:25 PDT 
All reviewed patches have been landed.  Closing bug.