Expand an object in heap profiler and sort e.g. by retained size. The order of object fields does not change.
Created attachment 146283 [details] Patch
Comment on attachment 146283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146283&action=review > LayoutTests/ChangeLog:7 > + A recent change to heap profiler has replaced getters with functions. > + Function calls were missing in couple places after that change. please explain the idea of changes in test framework > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:50 > + setTimeout(step3, 0); please don't use setTimeout in tests. Actually it is a road to flakiness hell. > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:56 > + setTimeout(next, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:78 > + setTimeout(step3, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:41 > + setTimeout(step3, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:47 > + setTimeout(next, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:72 > + setTimeout(step3, 0); ditto
Created attachment 146287 [details] Patch
Comment on attachment 146287 [details] Patch lgtm
Comment on attachment 146287 [details] Patch Clearing flags on attachment: 146287 Committed r119722: <http://trac.webkit.org/changeset/119722>
All reviewed patches have been landed. Closing bug.