Bug 88532 - Web Inspector: REGRESSION sorting of object fields is broken in heap profiler
Summary: Web Inspector: REGRESSION sorting of object fields is broken in heap profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexei Filippov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 06:44 PDT by Alexei Filippov
Modified: 2012-06-07 07:41 PDT (History)
12 users (show)

See Also:


Attachments
Patch (19.32 KB, patch)
2012-06-07 07:11 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (19.60 KB, patch)
2012-06-07 07:33 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2012-06-07 06:44:55 PDT
Expand an object in heap profiler and sort e.g. by retained size. The order of object fields does not change.
Comment 1 Alexei Filippov 2012-06-07 07:11:08 PDT
Created attachment 146283 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-06-07 07:20:03 PDT
Comment on attachment 146283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146283&action=review

> LayoutTests/ChangeLog:7
> +        A recent change to heap profiler has replaced getters with functions.
> +        Function calls were missing in couple places after that change.

please explain the idea of changes in test framework

> LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:50
> +                setTimeout(step3, 0);

please don't use setTimeout in tests. Actually it is a road to flakiness hell.

> LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:56
> +                    setTimeout(next, 0);

ditto

> LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:78
> +                setTimeout(step3, 0);

ditto

> LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:41
> +                setTimeout(step3, 0);

ditto

> LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:47
> +                    setTimeout(next, 0);

ditto

> LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:72
> +                setTimeout(step3, 0);

ditto
Comment 3 Alexei Filippov 2012-06-07 07:33:17 PDT
Created attachment 146287 [details]
Patch
Comment 4 Ilya Tikhonovsky 2012-06-07 07:34:39 PDT
Comment on attachment 146287 [details]
Patch

lgtm
Comment 5 Ilya Tikhonovsky 2012-06-07 07:41:42 PDT
Comment on attachment 146287 [details]
Patch

Clearing flags on attachment: 146287

Committed r119722: <http://trac.webkit.org/changeset/119722>
Comment 6 Ilya Tikhonovsky 2012-06-07 07:41:50 PDT
All reviewed patches have been landed.  Closing bug.