Bug 88531 – [Qt][WK2] Fix custom device pixel ratio propagation and add QML API tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Alexander Færøy]

SSIA.

[Alexander Færøy]

Created attachment 146278 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 146278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146278&action=review

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml:32
> +            webView.experimental.devicePixelRatio = 0.2

Why not just use 2.0

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml:35
> +            webView.experimental.evaluateJavaScript(

Why no test for the media query?

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml:36
> +                "(function() { return window.devicePixelRatio })()",

isnt this called webkitDevicePixelRatio?

[Alexander Færøy]

Created attachment 146288 [details]
Patch

[Csaba Osztrogonác]

Landed in http://trac.webkit.org/changeset/119723,
but there are two failing API tests:

XPASS  : qmltests::DevicePixelRatio::test_devicePixelRatio() '' returned TRUE unexpectedly. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(33)]
XPASS  : qmltests::DevicePixelRatio::test_devicePixelRatioMediaQuery() '' returned TRUE unexpectedly. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(51)]

Could you check it, please?

[Csaba Osztrogonác]

The patch landed, so we should close it ... But don't forget that it is incorrect - https://bugs.webkit.org/show_bug.cgi?id=88870

[Csaba Osztrogonác]

(In reply to comment #5)
> The patch landed, so we should close it ... But don't forget that it is incorrect - https://bugs.webkit.org/show_bug.cgi?id=88870

Guys, please answer and don't ignore this bug ...

[Csaba Osztrogonác]

Reopen, because it was rolled out by http://trac.webkit.org/changeset/124923.
See https://bugs.webkit.org/show_bug.cgi?id=88870 for details.

[Andras Becsi]

Created attachment 160203 [details]
proposed patch

[Kenneth Rohde Christiansen]

Comment on attachment 160203 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160203&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:803
> +    // Set the custom device pixel ratio requested from QML
> +    // as soon as the content item has a valid size.
> +    webPageProxy->setCustomDeviceScaleFactor(m_customDevicePixelRatio);

It ignores it if not? Why does it do that?

[Andras Becsi]

(In reply to comment #9)
> (From update of attachment 160203 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160203&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:803
> > +    // Set the custom device pixel ratio requested from QML
> > +    // as soon as the content item has a valid size.
> > +    webPageProxy->setCustomDeviceScaleFactor(m_customDevicePixelRatio);
> 
> It ignores it if not? Why does it do that?

The DrawingAreaProxy returns early if the page size is empty and the time when the experimental property is set the QML page item has no valid size yet thus the information does not reach the web process.

[Kenneth Rohde Christiansen]

(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 160203 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=160203&action=review
> > 
> > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:803
> > > +    // Set the custom device pixel ratio requested from QML
> > > +    // as soon as the content item has a valid size.
> > > +    webPageProxy->setCustomDeviceScaleFactor(m_customDevicePixelRatio);
> > 
> > It ignores it if not? Why does it do that?
> 
> The DrawingAreaProxy returns early if the page size is empty and the time when the experimental property is set the QML page item has no valid size yet thus the information does not reach the web process.

I think that comment there would be quite valuable.

[Andras Becsi]

Created attachment 160392 [details]
proposed patch

With additional comment explaining the issue.

[Andras Becsi]

Comment on attachment 160392 [details]
proposed patch

Clearing flags on attachment: 160392

Committed r126582: <http://trac.webkit.org/changeset/126582>

[Andras Becsi]

All reviewed patches have been landed.  Closing bug.